Changeset 45926 for trunk/src/wp-admin/includes/class-theme-upgrader-skin.php

Timestamp:

09/01/2019 05:12:43 PM (5 years ago)

Author:

SergeyBiryukov

Message:

I18N: Improve translator comments.

• Add missing translator comments.
• Fix placement of some translator comments. Translator comments should be on the line directly above the line containing the translation function call for optimal compatibility with various .pot file generation tools. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translator comments.

Includes minor code layout fixes.

Polyglots, rejoice! All WordPress core files now have translator comments for all strings with placeholders!

Props jrf, subrataemfluence, GaryJ, webdados, Dency, swissspidy, alvarogois, marcomartins, mihaiiceyro, vladwtz, niq1982, flipkeijzer, michielatyoast, chandrapatel, thrijith, joshuanoyce, FesoVik, tessak22, bhaktirajdev, cleancoded, dhavalkasvala, garrett-eclipse, bibliofille, socalchristina, priyankkpatel, 5hel2l2y, adamsilverstein, JeffPaul, pierlo, SergeyBiryukov.
Fixes #44360.

File:

• trunk/src/wp-admin/includes/class-theme-upgrader-skin.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-theme-upgrader-skin.php

@@ -65 +65 @@
                 admin_url( 'customize.php' )
             );
+
             if ( get_stylesheet() == $stylesheet ) {
                 if ( current_user_can( 'edit_theme_options' ) && current_user_can( 'customize' ) ) {
-                    $update_actions['preview']  = '<a href="' . esc_url( $customize_url ) . '" class="hide-if-no-customize load-customize">';
-                    $update_actions['preview'] .= '<span aria-hidden="true">' . __( 'Customize' ) . '</span>';
-                    /* translators: %s: theme name */
-                    $update_actions['preview'] .= '<span class="screen-reader-text">' . sprintf( __( 'Customize &#8220;%s&#8221;' ), $name ) . '</span></a>';
+                    $update_actions['preview'] = sprintf(
+                        '<a href="%s" class="hide-if-no-customize load-customize">' .
+                        '<span aria-hidden="true">%s</span><span class="screen-reader-text">%s</span></a>',
+                        esc_url( $customize_url ),
+                        __( 'Customize' ),
+                        /* translators: %s: theme name */
+                        sprintf( __( 'Customize &#8220;%s&#8221;' ), $name )
+                    );
                 }
             } elseif ( current_user_can( 'switch_themes' ) ) {
                 if ( current_user_can( 'edit_theme_options' ) && current_user_can( 'customize' ) ) {
-                    $update_actions['preview']  = '<a href="' . esc_url( $customize_url ) . '" class="hide-if-no-customize load-customize">';
-                    $update_actions['preview'] .= '<span aria-hidden="true">' . __( 'Live Preview' ) . '</span>';
+                    $update_actions['preview'] = sprintf(
+                        '<a href="%s" class="hide-if-no-customize load-customize">' .
+                        '<span aria-hidden="true">%s</span><span class="screen-reader-text">%s</span></a>',
+                        esc_url( $customize_url ),
+                        __( 'Live Preview' ),
+                        /* translators: %s: theme name */
+                        sprintf( __( 'Live Preview &#8220;%s&#8221;' ), $name )
+                    );
+                }
+
+                $update_actions['activate'] = sprintf(
+                    '<a href="%s" class="activatelink">' .
+                    '<span aria-hidden="true">%s</span><span class="screen-reader-text">%s</span></a>',
+                    esc_url( $activate_link ),
+                    __( 'Activate' ),
                     /* translators: %s: theme name */
-                    $update_actions['preview'] .= '<span class="screen-reader-text">' . sprintf( __( 'Live Preview &#8220;%s&#8221;' ), $name ) . '</span></a>';
-                }
-                $update_actions['activate']  = '<a href="' . esc_url( $activate_link ) . '" class="activatelink">';
-                $update_actions['activate'] .= '<span aria-hidden="true">' . __( 'Activate' ) . '</span>';
-                /* translators: %s: theme name */
-                $update_actions['activate'] .= '<span class="screen-reader-text">' . sprintf( __( 'Activate &#8220;%s&#8221;' ), $name ) . '</span></a>';
+                    sprintf( __( 'Activate &#8220;%s&#8221;' ), $name )
+                );
             }
 
@@ -90 +104 @@
         }
 
-        $update_actions['themes_page'] = '<a href="' . self_admin_url( 'themes.php' ) . '" target="_parent">' . __( 'Return to Themes page' ) . '</a>';
+        $update_actions['themes_page'] = sprintf(
+            '<a href="%s" target="_parent">%s</a>',
+            self_admin_url( 'themes.php' ),
+            __( 'Return to Themes page' )
+        );
 
         /**