Changeset 45926 for trunk/src/wp-admin/includes/class-wp-themes-list-table.php

Timestamp:

09/01/2019 05:12:43 PM (7 years ago)

Author:

SergeyBiryukov

Message:

I18N: Improve translator comments.

• Add missing translator comments.
• Fix placement of some translator comments. Translator comments should be on the line directly above the line containing the translation function call for optimal compatibility with various .pot file generation tools. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translator comments.

Includes minor code layout fixes.

Polyglots, rejoice! All WordPress core files now have translator comments for all strings with placeholders!

Props jrf, subrataemfluence, GaryJ, webdados, Dency, swissspidy, alvarogois, marcomartins, mihaiiceyro, vladwtz, niq1982, flipkeijzer, michielatyoast, chandrapatel, thrijith, joshuanoyce, FesoVik, tessak22, bhaktirajdev, cleancoded, dhavalkasvala, garrett-eclipse, bibliofille, socalchristina, priyankkpatel, 5hel2l2y, adamsilverstein, JeffPaul, pierlo, SergeyBiryukov.
Fixes #44360.

File:

• trunk/src/wp-admin/includes/class-wp-themes-list-table.php (modified) (5 diffs)

trunk/src/wp-admin/includes/class-wp-themes-list-table.php

@@ -98 +98 @@
                 if ( is_multisite() ) {
                         if ( current_user_can( 'install_themes' ) && current_user_can( 'manage_network_themes' ) ) {
-                                printf( __( 'You only have one theme enabled for this site right now. Visit the Network Admin to <a href="%1$s">enable</a> or <a href="%2$s">install</a> more themes.' ), network_admin_url( 'site-themes.php?id=' . $blog_id ), network_admin_url( 'theme-install.php' ) );
+                                printf(
+                                        /* translators: 1: URL to Themes tab on Edit Site screen, 2: URL to Add Themes screen */
+                                        __( 'You only have one theme enabled for this site right now. Visit the Network Admin to <a href="%1$s">enable</a> or <a href="%2$s">install</a> more themes.' ),
+                                        network_admin_url( 'site-themes.php?id=' . $blog_id ),
+                                        network_admin_url( 'theme-install.php' )
+                                );
 
                                 return;
                         } elseif ( current_user_can( 'manage_network_themes' ) ) {
-                                printf( __( 'You only have one theme enabled for this site right now. Visit the Network Admin to <a href="%1$s">enable</a> more themes.' ), network_admin_url( 'site-themes.php?id=' . $blog_id ) );
+                                printf(
+                                        /* translators: %s: URL to Themes tab on Edit Site screen */
+                                        __( 'You only have one theme enabled for this site right now. Visit the Network Admin to <a href="%s">enable</a> more themes.' ),
+                                        network_admin_url( 'site-themes.php?id=' . $blog_id )
+                                );
 
                                 return;
@@ -109 +118 @@
                 } else {
                         if ( current_user_can( 'install_themes' ) ) {
-                                printf( __( 'You only have one theme installed right now. Live a little! You can choose from over 1,000 free themes in the WordPress Theme Directory at any time: just click on the <a href="%s">Install Themes</a> tab above.' ), admin_url( 'theme-install.php' ) );
+                                printf(
+                                        /* translators: %s: URL to Add Themes screen */
+                                        __( 'You only have one theme installed right now. Live a little! You can choose from over 1,000 free themes in the WordPress Theme Directory at any time: just click on the <a href="%s">Install Themes</a> tab above.' ),
+                                        admin_url( 'theme-install.php' )
+                                );
 
                                 return;
@@ -115 +128 @@
                 }
                 // Fallthrough.
-                printf( __( 'Only the current theme is available to you. Contact the %s administrator for information about accessing additional themes.' ), get_site_option( 'site_name' ) );
+                printf(
+                        /* translators: %s: network title */
+                        __( 'Only the current theme is available to you. Contact the %s administrator for information about accessing additional themes.' ),
+                        get_site_option( 'site_name' )
+                );
         }
 
@@ -187 +204 @@
 
                         $actions             = array();
-                        $actions['activate'] = '<a href="' . $activate_link . '" class="activatelink" title="'
-                                . esc_attr( sprintf( __( 'Activate &#8220;%s&#8221;' ), $title ) ) . '">' . __( 'Activate' ) . '</a>';
+                        $actions['activate'] = sprintf(
+                                '<a href="%s" class="activatelink" title="%s">%s</a>',
+                                $activate_link,
+                                /* translators: %s: theme name */
+                                esc_attr( sprintf( __( 'Activate &#8220;%s&#8221;' ), $title ) ),
+                                __( 'Activate' )
+                        );
 
                         if ( current_user_can( 'edit_theme_options' ) && current_user_can( 'customize' ) ) {
-                                $actions['preview'] .= '<a href="' . wp_customize_url( $stylesheet ) . '" class="load-customize hide-if-no-customize">'
-                                        . __( 'Live Preview' ) . '</a>';
+                                $actions['preview'] .= sprintf(
+                                        '<a href="%s" class="load-customize hide-if-no-customize">%s</a>',
+                                        wp_customize_url( $stylesheet ),
+                                        __( 'Live Preview' )
+                                );
                         }
 
                         if ( ! is_multisite() && current_user_can( 'delete_themes' ) ) {
-                                $actions['delete'] = '<a class="submitdelete deletion" href="' . wp_nonce_url( 'themes.php?action=delete&amp;stylesheet=' . urlencode( $stylesheet ), 'delete-theme_' . $stylesheet )
-                                        . '" onclick="' . "return confirm( '" . esc_js( sprintf( __( "You are about to delete this theme '%s'\n  'Cancel' to stop, 'OK' to delete." ), $title ) )
-                                        . "' );" . '">' . __( 'Delete' ) . '</a>';
+                                $actions['delete'] = sprintf(
+                                        '<a class="submitdelete deletion" href="%s" onclick="return confirm( \'%s\' );">%s</a>',
+                                        wp_nonce_url( 'themes.php?action=delete&amp;stylesheet=' . urlencode( $stylesheet ), 'delete-theme_' . $stylesheet ),
+                                        /* translators: %s: theme name */
+                                        esc_js( sprintf( __( "You are about to delete this theme '%s'\n  'Cancel' to stop, 'OK' to delete." ), $title ) ),
+                                        __( 'Delete' )
+                                );
                         }
 
@@ -224 +253 @@
 
                         <h3><?php echo $title; ?></h3>
-                        <div class="theme-author"><?php printf( __( 'By %s' ), $author ); ?></div>
+                        <div class="theme-author">
+                                <?php
+                                        /* translators: %s: theme author */
+                                        printf( __( 'By %s' ), $author );
+                                ?>
+                        </div>
                         <div class="action-links">
                                 <ul>