Changeset 45926 for trunk/src/wp-admin/includes/dashboard.php

Timestamp:

09/01/2019 05:12:43 PM (7 years ago)

Author:

SergeyBiryukov

Message:

I18N: Improve translator comments.

• Add missing translator comments.
• Fix placement of some translator comments. Translator comments should be on the line directly above the line containing the translation function call for optimal compatibility with various .pot file generation tools. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translator comments.

Includes minor code layout fixes.

Polyglots, rejoice! All WordPress core files now have translator comments for all strings with placeholders!

Props jrf, subrataemfluence, GaryJ, webdados, Dency, swissspidy, alvarogois, marcomartins, mihaiiceyro, vladwtz, niq1982, flipkeijzer, michielatyoast, chandrapatel, thrijith, joshuanoyce, FesoVik, tessak22, bhaktirajdev, cleancoded, dhavalkasvala, garrett-eclipse, bibliofille, socalchristina, priyankkpatel, 5hel2l2y, adamsilverstein, JeffPaul, pierlo, SergeyBiryukov.
Fixes #44360.

File:

• trunk/src/wp-admin/includes/dashboard.php (modified) (9 diffs)

trunk/src/wp-admin/includes/dashboard.php

@@ -270 +270 @@
                 if ( $num_posts && $num_posts->publish ) {
                         if ( 'post' == $post_type ) {
+                                /* translators: %s: number of posts */
                                 $text = _n( '%s Post', '%s Posts', $num_posts->publish );
                         } else {
+                                /* translators: %s: number of pages */
                                 $text = _n( '%s Page', '%s Pages', $num_posts->publish );
                         }
@@ -286 +288 @@
         $num_comm = wp_count_comments();
         if ( $num_comm && ( $num_comm->approved || $num_comm->moderated ) ) {
+                /* translators: %s: number of comments */
                 $text = sprintf( _n( '%s Comment', '%s Comments', $num_comm->approved ), number_format_i18n( $num_comm->approved ) );
                 ?>
@@ -291 +294 @@
                 <?php
                 $moderated_comments_count_i18n = number_format_i18n( $num_comm->moderated );
-                /* translators: %s: number of comments in moderation */
+                /* translators: %s: number of comments */
                 $text = sprintf( _n( '%s Comment in moderation', '%s Comments in moderation', $num_comm->moderated ), $moderated_comments_count_i18n );
                 ?>
@@ -581 +584 @@
         echo '<div class="drafts">';
         if ( count( $drafts ) > 3 ) {
-                echo '<p class="view-all"><a href="' . esc_url( admin_url( 'edit.php?post_status=draft' ) ) . '">' . __( 'View all drafts' ) . "</a></p>\n";
+                printf(
+                        '<p class="view-all"><a href="%s">%s</a></p>' . "\n",
+                        esc_url( admin_url( 'edit.php?post_status=draft' ) ),
+                        __( 'View all drafts' )
+                );
         }
         echo '<h2 class="hide-if-no-js">' . __( 'Your Recent Drafts' ) . "</h2>\n<ul>";
@@ -593 +600 @@
                 $title = _draft_or_post_title( $draft->ID );
                 echo "<li>\n";
-                /* translators: %s: post title */
-                echo '<div class="draft-title"><a href="' . esc_url( $url ) . '" aria-label="' . esc_attr( sprintf( __( 'Edit &#8220;%s&#8221;' ), $title ) ) . '">' . esc_html( $title ) . '</a>';
-                echo '<time datetime="' . get_the_time( 'c', $draft ) . '">' . get_the_time( __( 'F j, Y' ), $draft ) . '</time></div>';
+                printf(
+                        '<div class="draft-title"><a href="%s" aria-label="%s">%s</a><time datetime="%s">%s</time></div>',
+                        esc_url( $url ),
+                        /* translators: %s: post title */
+                        esc_attr( sprintf( __( 'Edit &#8220;%s&#8221;' ), $title ) ),
+                        esc_html( $title ),
+                        get_the_time( 'c', $draft ),
+                        get_the_time( __( 'F j, Y' ), $draft )
+                );
                 $the_content = wp_trim_words( $draft->post_content, $draft_length );
                 if ( $the_content ) {
@@ -1496 +1509 @@
         if ( $response ) {
                 if ( $response['insecure'] ) {
-                        /* translators: %s: browser name and link */
                         $msg = sprintf(
+                                /* translators: %s: browser name and link */
                                 __( "It looks like you're using an insecure version of %s. Using an outdated browser makes your computer unsafe. For the best WordPress experience, please update your browser." ),
                                 sprintf( '<a href="%s">%s</a>', esc_url( $response['update_url'] ), esc_html( $response['name'] ) )
                         );
                 } else {
-                        /* translators: %s: browser name and link */
                         $msg = sprintf(
+                                /* translators: %s: browser name and link */
                                 __( "It looks like you're using an old version of %s. For the best WordPress experience, please update your browser." ),
                                 sprintf( '<a href="%s">%s</a>', esc_url( $response['update_url'] ), esc_html( $response['name'] ) )
@@ -1524 +1537 @@
                 }
 
-                $notice .= '<p>' . sprintf( __( '<a href="%1$s" class="update-browser-link">Update %2$s</a> or learn how to <a href="%3$s" class="browse-happy-link">browse happy</a>' ), esc_attr( $response['update_url'] ), esc_html( $response['name'] ), esc_url( $browsehappy ) ) . '</p>';
+                $notice .= '<p>' . sprintf(
+                        /* translators: 1: browser update URL, 2: browser name, 3: Browse Happy URL */
+                        __( '<a href="%1$s" class="update-browser-link">Update %2$s</a> or learn how to <a href="%3$s" class="browse-happy-link">browse happy</a>' ),
+                        esc_attr( $response['update_url'] ),
+                        esc_html( $response['name'] ),
+                        esc_url( $browsehappy )
+                ) . '</p>';
                 $notice .= '<p class="hide-if-no-js"><a href="" class="dismiss" aria-label="' . esc_attr__( 'Dismiss the browser warning panel' ) . '">' . __( 'Dismiss' ) . '</a></p>';
                 $notice .= '<div class="clear"></div>';
@@ -1698 +1717 @@
                 <?php if ( current_user_can( 'install_themes' ) || ( current_user_can( 'switch_themes' ) && count( wp_get_themes( array( 'allowed' => true ) ) ) > 1 ) ) : ?>
                         <?php $themes_link = current_user_can( 'customize' ) ? add_query_arg( 'autofocus[panel]', 'themes', admin_url( 'customize.php' ) ) : admin_url( 'themes.php' ); ?>
-                        <p class="hide-if-no-customize"><?php printf( __( 'or, <a href="%s">change your theme completely</a>' ), $themes_link ); ?></p>
+                        <p class="hide-if-no-customize">
+                                <?php
+                                        /* translators: %s: URL to Themes panel in Customizer or Themes screen */
+                                        printf( __( 'or, <a href="%s">change your theme completely</a>' ), $themes_link );
+                                ?>
+                        </p>
                 <?php endif; ?>
         </div>
@@ -1726 +1750 @@
                         if ( current_theme_supports( 'widgets' ) && current_theme_supports( 'menus' ) ) {
                                 $widgets_menus_link = sprintf(
+                                        /* translators: 1: URL to Widgets screen, 2: URL to Menus screen */
                                         __( 'Manage <a href="%1$s">widgets</a> or <a href="%2$s">menus</a>' ),
                                         admin_url( 'widgets.php' ),