Changeset 45926 for trunk/src/wp-admin/includes/media.php

Timestamp:

09/01/2019 05:12:43 PM (6 years ago)

Author:

SergeyBiryukov

Message:

I18N: Improve translator comments.

• Add missing translator comments.
• Fix placement of some translator comments. Translator comments should be on the line directly above the line containing the translation function call for optimal compatibility with various .pot file generation tools. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translator comments.

Includes minor code layout fixes.

Polyglots, rejoice! All WordPress core files now have translator comments for all strings with placeholders!

Props jrf, subrataemfluence, GaryJ, webdados, Dency, swissspidy, alvarogois, marcomartins, mihaiiceyro, vladwtz, niq1982, flipkeijzer, michielatyoast, chandrapatel, thrijith, joshuanoyce, FesoVik, tessak22, bhaktirajdev, cleancoded, dhavalkasvala, garrett-eclipse, bibliofille, socalchristina, priyankkpatel, 5hel2l2y, adamsilverstein, JeffPaul, pierlo, SergeyBiryukov.
Fixes #44360.

File:

• trunk/src/wp-admin/includes/media.php (modified) (8 diffs)

trunk/src/wp-admin/includes/media.php

@@ -61 +61 @@
     }
 
+    /* translators: %s: number of attachments */
     $tabs['gallery'] = sprintf( __( 'Gallery (%s)' ), "<span id='attachments-count'>$attachments</span>" );
 
@@ -332 +333 @@
                 $content .= sprintf( __( '"%1$s" by %2$s.' ), $title, $meta['artist'] );
             } else {
-                /* translators: 1: audio track title */
+                /* translators: %s: audio track title */
                 $content .= sprintf( __( '"%s".' ), $title );
             }
@@ -1602 +1603 @@
         <tr><td colspan='2' class='imgedit-response' id='imgedit-response-$post->ID'></td></tr>\n
         <tr><td style='display:none' colspan='2' class='image-editor' id='image-editor-$post->ID'></td></tr>\n
-        <tr><td colspan='2'><p class='media-types media-types-required-info'>" . sprintf( __( 'Required fields are marked %s' ), '<span class="required">*</span>' ) . "</p></td></tr>\n";
+        <tr><td colspan='2'><p class='media-types media-types-required-info'>" .
+            /* translators: %s: an asterisk symbol (*) */
+            sprintf( __( 'Required fields are marked %s' ), '<span class="required">*</span>' ) .
+        "</p></td></tr>\n";
 
     $defaults = array(
@@ -1907 +1911 @@
     if ( $item ) {
         $item = '<p class="media-types media-types-required-info">' .
-            sprintf( __( 'Required fields are marked %s' ), '<span class="required">*</span>' ) . '</p>
-            <table class="compat-attachment-fields">' . $item . '</table>';
+            /* translators: %s: an asterisk symbol (*) */
+            sprintf( __( 'Required fields are marked %s' ), '<span class="required">*</span>' ) .
+            '</p>' .
+            '<table class="compat-attachment-fields">' . $item . '</table>';
     }
 
@@ -1957 +1963 @@
 
     if ( ! _device_can_upload() ) {
-        echo '<p>' . sprintf( __( 'The web browser on your device cannot be used to upload files. You may be able to use the <a href="%s">native app for your device</a> instead.' ), 'https://apps.wordpress.org/' ) . '</p>';
+        echo '<p>' . sprintf(
+            /* translators: %s: https://apps.wordpress.org/ */
+            __( 'The web browser on your device cannot be used to upload files. You may be able to use the <a href="%s">native app for your device</a> instead.' ),
+            'https://apps.wordpress.org/'
+        ) . '</p>';
         return;
     }
@@ -2131 +2141 @@
 </div>
 
-<p class="max-upload-size"><?php printf( __( 'Maximum upload file size: %s.' ), esc_html( size_format( $max_upload_size ) ) ); ?></p>
+<p class="max-upload-size">
+    <?php
+    /* translators: %s: maximum allowed file size */
+    printf( __( 'Maximum upload file size: %s.' ), esc_html( size_format( $max_upload_size ) ) );
+    ?>
+</p>
     <?php
 
@@ -2776 +2791 @@
     return '
     <p class="media-types"><label><input type="radio" name="media_type" value="image" id="image-only"' . checked( 'image-only', $view, false ) . ' /> ' . __( 'Image' ) . '</label> &nbsp; &nbsp; <label><input type="radio" name="media_type" value="generic" id="not-image"' . checked( 'not-image', $view, false ) . ' /> ' . __( 'Audio, Video, or Other File' ) . '</label></p>
-    <p class="media-types media-types-required-info">' . sprintf( __( 'Required fields are marked %s' ), '<span class="required">*</span>' ) . '</p>
+    <p class="media-types media-types-required-info">' .
+        /* translators: %s: an asterisk symbol (*) */
+        sprintf( __( 'Required fields are marked %s' ), '<span class="required">*</span>' ) .
+    '</p>
     <table class="describe ' . $table_class . '"><tbody>
         <tr>
@@ -2863 +2881 @@
     ?>
     <p class="upload-flash-bypass">
-    <?php printf( __( 'You are using the multi-file uploader. Problems? Try the <a href="%1$s" target="%2$s">browser uploader</a> instead.' ), $browser_uploader, '_blank' ); ?>
+    <?php
+        printf(
+            /* translators: 1: URL to browser uploader, 2: additional link attributes */
+            __( 'You are using the multi-file uploader. Problems? Try the <a href="%1$s" %2$s>browser uploader</a> instead.' ),
+            $browser_uploader,
+            'target="_blank"'
+        );
+    ?>
     </p>
     <?php