Changeset 45926 for trunk/src/wp-admin/includes/plugin-install.php

Timestamp:

09/01/2019 05:12:43 PM (5 years ago)

Author:

SergeyBiryukov

Message:

I18N: Improve translator comments.

• Add missing translator comments.
• Fix placement of some translator comments. Translator comments should be on the line directly above the line containing the translation function call for optimal compatibility with various .pot file generation tools. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translator comments.

Includes minor code layout fixes.

Polyglots, rejoice! All WordPress core files now have translator comments for all strings with placeholders!

Props jrf, subrataemfluence, GaryJ, webdados, Dency, swissspidy, alvarogois, marcomartins, mihaiiceyro, vladwtz, niq1982, flipkeijzer, michielatyoast, chandrapatel, thrijith, joshuanoyce, FesoVik, tessak22, bhaktirajdev, cleancoded, dhavalkasvala, garrett-eclipse, bibliofille, socalchristina, priyankkpatel, 5hel2l2y, adamsilverstein, JeffPaul, pierlo, SergeyBiryukov.
Fixes #44360.

File:

• trunk/src/wp-admin/includes/plugin-install.php (modified) (8 diffs)

trunk/src/wp-admin/includes/plugin-install.php

@@ -262 +262 @@
 function install_dashboard() {
     ?>
-    <p><?php printf( __( 'Plugins extend and expand the functionality of WordPress. You may automatically install plugins from the <a href="%1$s">WordPress Plugin Directory</a> or upload a plugin in .zip format by clicking the button at the top of this page.' ), __( 'https://wordpress.org/plugins/' ) ); ?></p>
+    <p>
+        <?php
+        printf(
+            /* translators: %s: https://wordpress.org/plugins/ */
+            __( 'Plugins extend and expand the functionality of WordPress. You may automatically install plugins from the <a href="%s">WordPress Plugin Directory</a> or upload a plugin in .zip format by clicking the button at the top of this page.' ),
+            __( 'https://wordpress.org/plugins/' )
+        );
+        ?>
+    </p>
 
     <?php display_plugins_table(); ?>
@@ -293 +301 @@
             $tags,
             array(
+                /* translators: %s: number of plugins */
                 'single_text'   => __( '%s plugin' ),
+                /* translators: %s: number of plugins */
                 'multiple_text' => __( '%s plugins' ),
             )
@@ -391 +401 @@
         case 'install_plugins_beta':
             printf(
+                /* translators: %s: URL to "Features as Plugins" page */
                 '<p>' . __( 'You are using a development version of WordPress. These feature plugins are also under development. <a href="%s">Learn more</a>.' ) . '</p>',
                 'https://make.wordpress.org/core/handbook/about/release-cycle/features-as-plugins/'
@@ -640 +651 @@
                 <li><strong><?php _e( 'Last Updated:' ); ?></strong>
                     <?php
-                    /* translators: %s: Time since the last update */
+                    /* translators: %s: Human-readable time difference */
                     printf( __( '%s ago' ), human_time_diff( strtotime( $api->last_updated ) ) );
                     ?>
@@ -668 +679 @@
                     $active_installs_millions = floor( $api->active_installs / 1000000 );
                     printf(
+                        /* translators: %s: number of millions */
                         _nx( '%s+ Million', '%s+ Million', $active_installs_millions, 'Active plugin installations' ),
                         number_format_i18n( $active_installs_millions )
@@ -697 +709 @@
             );
             ?>
-            <p aria-hidden="true" class="fyi-description"><?php printf( _n( '(based on %s rating)', '(based on %s ratings)', $api->num_ratings ), number_format_i18n( $api->num_ratings ) ); ?></p>
+            <p aria-hidden="true" class="fyi-description">
+                <?php
+                printf(
+                    /* translators: %s: number of ratings */
+                    _n( '(based on %s rating)', '(based on %s ratings)', $api->num_ratings ),
+                    number_format_i18n( $api->num_ratings )
+                );
+                ?>
+            </p>
             <?php
         }
@@ -708 +728 @@
             foreach ( $api->ratings as $key => $ratecount ) {
                 // Avoid div-by-zero.
-                $_rating = $api->num_ratings ? ( $ratecount / $api->num_ratings ) : 0;
-                /* translators: 1: number of stars (used to determine singular/plural), 2: number of reviews */
+                $_rating    = $api->num_ratings ? ( $ratecount / $api->num_ratings ) : 0;
                 $aria_label = esc_attr(
                     sprintf(
-                        _n( 'Reviews with %1$d star: %2$s. Opens in a new tab.', 'Reviews with %1$d stars: %2$s. Opens in a new tab.', $key ),
+                        /* translators: 1: number of stars (used to determine singular/plural), 2: number of reviews */
+                        _n(
+                            'Reviews with %1$d star: %2$s. Opens in a new tab.',
+                            'Reviews with %1$d stars: %2$s. Opens in a new tab.',
+                            $key
+                        ),
                         $key,
                         number_format_i18n( $ratecount )
@@ -720 +744 @@
                 <div class="counter-container">
                         <span class="counter-label">
-                            <a href="https://wordpress.org/support/plugin/<?php echo $api->slug; ?>/reviews/?filter=<?php echo $key; ?>"
-                                target="_blank" aria-label="<?php echo $aria_label; ?>"><?php printf( _n( '%d star', '%d stars', $key ), $key ); ?></a>
+                            <?php
+                            printf(
+                                '<a href="%s" target="_blank" aria-label="%s">%s</a>',
+                                "https://wordpress.org/support/plugin/{$api->slug}/reviews/?filter={$key}",
+                                $aria_label,
+                                /* translators: %s: number of stars */
+                                sprintf( _n( '%d star', '%d stars', $key ), $key )
+                            );
+                            ?>
                         </span>
                         <span class="counter-back">