Changeset 45926 for trunk/src/wp-includes/class-wp-theme.php

Timestamp:

09/01/2019 05:12:43 PM (6 years ago)

Author:

SergeyBiryukov

Message:

I18N: Improve translator comments.

• Add missing translator comments.
• Fix placement of some translator comments. Translator comments should be on the line directly above the line containing the translation function call for optimal compatibility with various .pot file generation tools. The CS auto-fixing, which changed some inconsistent function calls to multi-line function calls, is part of the reason why this was no longer the case for a select group of translator comments.

Includes minor code layout fixes.

Polyglots, rejoice! All WordPress core files now have translator comments for all strings with placeholders!

Props jrf, subrataemfluence, GaryJ, webdados, Dency, swissspidy, alvarogois, marcomartins, mihaiiceyro, vladwtz, niq1982, flipkeijzer, michielatyoast, chandrapatel, thrijith, joshuanoyce, FesoVik, tessak22, bhaktirajdev, cleancoded, dhavalkasvala, garrett-eclipse, bibliofille, socalchristina, priyankkpatel, 5hel2l2y, adamsilverstein, JeffPaul, pierlo, SergeyBiryukov.
Fixes #44360.

File:

• trunk/src/wp-includes/class-wp-theme.php (modified) (5 diffs)

trunk/src/wp-includes/class-wp-theme.php

@@ -227 +227 @@
             $this->headers['Name'] = $this->stylesheet;
             if ( ! file_exists( $this->theme_root . '/' . $this->stylesheet ) ) {
-                $this->errors = new WP_Error( 'theme_not_found', sprintf( __( 'The theme directory "%s" does not exist.' ), esc_html( $this->stylesheet ) ) );
+                $this->errors = new WP_Error(
+                    'theme_not_found',
+                    sprintf(
+                        /* translators: %s: theme directory name */
+                        __( 'The theme directory "%s" does not exist.' ),
+                        esc_html( $this->stylesheet )
+                    )
+                );
             } else {
                 $this->errors = new WP_Error( 'theme_no_stylesheet', __( 'Stylesheet is missing.' ) );
@@ -272 +279 @@
 
         if ( ! $this->template && $this->stylesheet === $this->headers['Template'] ) {
-            /* translators: %s: Template */
-            $this->errors = new WP_Error( 'theme_child_invalid', sprintf( __( 'The theme defines itself as its parent theme. Please check the %s header.' ), '<code>Template</code>' ) );
+            $this->errors = new WP_Error(
+                'theme_child_invalid',
+                sprintf(
+                    /* translators: %s: Template */
+                    __( 'The theme defines itself as its parent theme. Please check the %s header.' ),
+                    '<code>Template</code>'
+                )
+            );
             $this->cache_add(
                 'theme',
@@ -329 +342 @@
             } else {
                 // Parent theme is missing.
-                $this->errors = new WP_Error( 'theme_no_parent', sprintf( __( 'The parent theme is missing. Please install the "%s" parent theme.' ), esc_html( $this->template ) ) );
+                $this->errors = new WP_Error(
+                    'theme_no_parent',
+                    sprintf(
+                        /* translators: %s: theme directory name */
+                        __( 'The parent theme is missing. Please install the "%s" parent theme.' ),
+                        esc_html( $this->template )
+                    )
+                );
                 $this->cache_add(
                     'theme',
@@ -349 +369 @@
             if ( $_child instanceof WP_Theme && $_child->template == $this->stylesheet ) {
                 $_child->parent = null;
-                $_child->errors = new WP_Error( 'theme_parent_invalid', sprintf( __( 'The "%s" theme is not a valid parent theme.' ), esc_html( $_child->template ) ) );
+                $_child->errors = new WP_Error(
+                    'theme_parent_invalid',
+                    sprintf(
+                        /* translators: %s: theme directory name */
+                        __( 'The "%s" theme is not a valid parent theme.' ),
+                        esc_html( $_child->template )
+                    )
+                );
                 $_child->cache_add(
                     'theme',
@@ -361 +388 @@
                 // The two themes actually reference each other with the Template header.
                 if ( $_child->stylesheet == $this->template ) {
-                    $this->errors = new WP_Error( 'theme_parent_invalid', sprintf( __( 'The "%s" theme is not a valid parent theme.' ), esc_html( $this->template ) ) );
+                    $this->errors = new WP_Error(
+                        'theme_parent_invalid',
+                        sprintf(
+                            /* translators: %s: theme directory name */
+                            __( 'The "%s" theme is not a valid parent theme.' ),
+                            esc_html( $this->template )
+                        )
+                    );
                     $this->cache_add(
                         'theme',