Changeset 45930 for trunk/src/wp-includes/customize/class-wp-customize-date-time-control.php

Timestamp:

09/02/2019 09:43:39 PM (5 years ago)

Author:

afercia

Message:

Accessibility: Audit usage of abbreviations.

Title attributes on abbreviations are only available to a minority of users. The
best option is to avoid unnecessary abbreviations when possible. In the other cases,
use an <abbr> element (which provides a hint to user agents on how to announce
and display the abbreviation) and provide an expansion in plain text on first use.

• readme.html: improves abbreviations and removes unnecessary title attributes
• options-general: removes unnecessary abbreviations and improves the remaining ones
• customizer schedule changeset date: removes unnecessary abbreviations and improves the remaining ones
• posts table date: uses a span element instead of an abbr element because this is not an abbreviation

Fixes #46980.

File:

• trunk/src/wp-includes/customize/class-wp-customize-date-time-control.php (modified) (2 diffs)

trunk/src/wp-includes/customize/class-wp-customize-date-time-control.php

@@ -174 +174 @@
                             </select>
                         <# } #>
-                        <abbr class="date-timezone" aria-label="<?php esc_attr_e( 'Timezone' ); ?>" title="<?php echo esc_attr( $timezone_info['description'] ); ?>"><?php echo esc_html( $timezone_info['abbr'] ); ?></abbr>
+                        <p><?php echo $timezone_info['description']; ?></p>
                     </div>
                 </fieldset>
@@ -229 +229 @@
             if ( $tz ) {
                 $now                   = new DateTime( 'now', $tz );
-                $formatted_gmt_offset  = sprintf( 'UTC%s', $this->format_gmt_offset( $tz->getOffset( $now ) / 3600 ) );
+                $formatted_gmt_offset  = $this->format_gmt_offset( $tz->getOffset( $now ) / 3600 );
                 $tz_name               = str_replace( '_', ' ', $tz->getName() );
                 $timezone_info['abbr'] = $now->format( 'T' );
 
-                /* translators: 1: timezone name, 2: timezone abbreviation, 3: gmt offset  */
-                $timezone_info['description'] = sprintf( __( 'Timezone is %1$s (%2$s), currently %3$s.' ), $tz_name, $timezone_info['abbr'], $formatted_gmt_offset );
+                $timezone_info['description'] = sprintf(
+                    /* translators: 1: timezone name, 2: timezone abbreviation, 3: UTC abbreviation and offset, 4: UTC offset  */
+                    __( 'Your timezone is set to %1$s (%2$s), currently %3$s (Coordinated Universal Time %4$s).' ),
+                    $tz_name,
+                    '<abbr>' . $timezone_info['abbr'] . '</abbr>',
+                    '<abbr>UTC</abbr>' . $formatted_gmt_offset,
+                    $formatted_gmt_offset
+                );
             } else {
                 $timezone_info['description'] = '';
             }
         } else {
-            $formatted_gmt_offset  = $this->format_gmt_offset( intval( get_option( 'gmt_offset', 0 ) ) );
-            $timezone_info['abbr'] = sprintf( 'UTC%s', $formatted_gmt_offset );
-
-            /* translators: %s: UTC offset  */
-            $timezone_info['description'] = sprintf( __( 'Timezone is %s.' ), $timezone_info['abbr'] );
+            $formatted_gmt_offset = $this->format_gmt_offset( intval( get_option( 'gmt_offset', 0 ) ) );
+
+            $timezone_info['description'] = sprintf(
+                /* translators: 1: UTC abbreviation and offset, 2: UTC offset */
+                __( 'Your timezone is set to %1$s (Coordinated Universal Time %2$s).' ),
+                '<abbr>UTC</abbr>' . $formatted_gmt_offset,
+                $formatted_gmt_offset
+            );
         }