Changeset 45936

Timestamp:

09/04/2019 04:08:03 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Escape the output in wp_ajax_upload_attachment().

Props whyisjake, sstoqnov.

Location:

trunk/src/wp-admin

Files:

• async-upload.php (modified) (1 diff)
• includes/ajax-actions.php (modified) (4 diffs)

trunk/src/wp-admin/async-upload.php

@@ -23 +23 @@
 require_once( ABSPATH . 'wp-admin/admin.php' );
 
-header( 'Content-Type: text/html; charset=' . get_option( 'blog_charset' ) );
+header( 'Content-Type: text/plain; charset=' . get_option( 'blog_charset' ) );
 
 if ( isset( $_REQUEST['action'] ) && 'upload-attachment' === $_REQUEST['action'] ) {

trunk/src/wp-admin/includes/ajax-actions.php

@@ -2509 +2509 @@
                                 'data'    => array(
                                         'message'  => __( 'Sorry, you are not allowed to upload files.' ),
-                                        'filename' => $_FILES['async-upload']['name'],
+                                        'filename' => esc_html( $_FILES['async-upload']['name'] ),
                                 ),
                         )
@@ -2526 +2526 @@
                                         'data'    => array(
                                                 'message'  => __( 'Sorry, you are not allowed to attach files to this post.' ),
-                                                'filename' => $_FILES['async-upload']['name'],
+                                                'filename' => esc_html( $_FILES['async-upload']['name'] ),
                                         ),
                                 )
@@ -2553 +2553 @@
                                         'data'    => array(
                                                 'message'  => __( 'The uploaded file is not a valid image. Please try again.' ),
-                                                'filename' => $_FILES['async-upload']['name'],
+                                                'filename' => esc_html( $_FILES['async-upload']['name'] ),
                                         ),
                                 )
@@ -2570 +2570 @@
                                 'data'    => array(
                                         'message'  => $attachment_id->get_error_message(),
-                                        'filename' => $_FILES['async-upload']['name'],
+                                        'filename' => esc_html( $_FILES['async-upload']['name'] ),
                                 ),
                         )