Changeset 45939

Timestamp:

09/04/2019 04:17:53 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Escape the output in wp_ajax_upload_attachment().

Merges [45936] to the 5.1 branch.
Props whyisjake, sstoqnov.

Location:

branches/5.1

Files:

• . (modified) (1 prop)
• src/wp-admin/async-upload.php (modified) (1 diff)
• src/wp-admin/includes/ajax-actions.php (modified) (4 diffs)

branches/5.1/src/wp-admin/async-upload.php

@@ -23 +23 @@
 require_once( ABSPATH . 'wp-admin/admin.php' );
 
-header( 'Content-Type: text/html; charset=' . get_option( 'blog_charset' ) );
+header( 'Content-Type: text/plain; charset=' . get_option( 'blog_charset' ) );
 
 if ( isset( $_REQUEST['action'] ) && 'upload-attachment' === $_REQUEST['action'] ) {

branches/5.1/src/wp-admin/includes/ajax-actions.php

@@ -2304 +2304 @@
                 'data'    => array(
                     'message'  => __( 'Sorry, you are not allowed to upload files.' ),
-                    'filename' => $_FILES['async-upload']['name'],
+                    'filename' => esc_html( $_FILES['async-upload']['name'] ),
                 ),
             )
@@ -2320 +2320 @@
                     'data'    => array(
                         'message'  => __( 'Sorry, you are not allowed to attach files to this post.' ),
-                        'filename' => $_FILES['async-upload']['name'],
+                        'filename' => esc_html( $_FILES['async-upload']['name'] ),
                     ),
                 )
@@ -2346 +2346 @@
                     'data'    => array(
                         'message'  => __( 'The uploaded file is not a valid image. Please try again.' ),
-                        'filename' => $_FILES['async-upload']['name'],
+                        'filename' => esc_html( $_FILES['async-upload']['name'] ),
                     ),
                 )
@@ -2363 +2363 @@
                 'data'    => array(
                     'message'  => $attachment_id->get_error_message(),
-                    'filename' => $_FILES['async-upload']['name'],
+                    'filename' => esc_html( $_FILES['async-upload']['name'] ),
                 ),
             )