Changeset 45944

Timestamp:

09/04/2019 04:30:11 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Escape the output in wp_ajax_upload_attachment().

Merges [45936] to the 4.8 branch.
Props whyisjake, sstoqnov.

Location:

branches/4.8

Files:

• . (modified) (1 prop)
• src/wp-admin/async-upload.php (modified) (1 diff)
• src/wp-admin/includes/ajax-actions.php (modified) (4 diffs)

branches/4.8/src/wp-admin/async-upload.php

@@ -33 +33 @@
 require_once( ABSPATH . 'wp-admin/admin.php' );
 
-header( 'Content-Type: text/html; charset=' . get_option( 'blog_charset' ) );
+header( 'Content-Type: text/plain; charset=' . get_option( 'blog_charset' ) );
 
 if ( isset( $_REQUEST['action'] ) && 'upload-attachment' === $_REQUEST['action'] ) {

branches/4.8/src/wp-admin/includes/ajax-actions.php

@@ -2066 +2066 @@
             'data'    => array(
                 'message'  => __( 'Sorry, you are not allowed to upload files.' ),
-                'filename' => $_FILES['async-upload']['name'],
+                'filename' => esc_html( $_FILES['async-upload']['name'] ),
             )
         ) );
@@ -2080 +2080 @@
                 'data'    => array(
                     'message'  => __( 'Sorry, you are not allowed to attach files to this post.' ),
-                    'filename' => $_FILES['async-upload']['name'],
+                    'filename' => esc_html( $_FILES['async-upload']['name'] ),
                 )
             ) );
@@ -2104 +2104 @@
                 'data'    => array(
                     'message'  => __( 'The uploaded file is not a valid image. Please try again.' ),
-                    'filename' => $_FILES['async-upload']['name'],
+                    'filename' => esc_html( $_FILES['async-upload']['name'] ),
                 )
             ) );
@@ -2119 +2119 @@
             'data'    => array(
                 'message'  => $attachment_id->get_error_message(),
-                'filename' => $_FILES['async-upload']['name'],
+                'filename' => esc_html( $_FILES['async-upload']['name'] ),
             )
         ) );