Changeset 45951 for branches/4.4/src/wp-admin/includes/ajax-actions.php

Timestamp:

09/04/2019 04:36:13 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Escape the output in wp_ajax_upload_attachment().

Merges [45936] to the 4.4 branch.
Props whyisjake, sstoqnov.

Location:

branches/4.4

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/ajax-actions.php (modified) (4 diffs)

branches/4.4/src/wp-admin/includes/ajax-actions.php

@@ -1997 +1997 @@
                         'data'    => array(
                                 'message'  => __( 'You do not have permission to upload files.' ),
-                                'filename' => $_FILES['async-upload']['name'],
+                                'filename' => esc_html( $_FILES['async-upload']['name'] ),
                         )
                 ) );
@@ -2011 +2011 @@
                                 'data'    => array(
                                         'message'  => __( "You don't have permission to attach files to this post." ),
-                                        'filename' => $_FILES['async-upload']['name'],
+                                        'filename' => esc_html( $_FILES['async-upload']['name'] ),
                                 )
                         ) );
@@ -2035 +2035 @@
                                 'data'    => array(
                                         'message'  => __( 'The uploaded file is not a valid image. Please try again.' ),
-                                        'filename' => $_FILES['async-upload']['name'],
+                                        'filename' => esc_html( $_FILES['async-upload']['name'] ),
                                 )
                         ) );
@@ -2050 +2050 @@
                         'data'    => array(
                                 'message'  => $attachment_id->get_error_message(),
-                                'filename' => $_FILES['async-upload']['name'],
+                                'filename' => esc_html( $_FILES['async-upload']['name'] ),
                         )
                 ) );