Changeset 45966

Timestamp:

09/04/2019 04:46:27 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Escape the output in wp_ajax_upload_attachment().

Merges [45936] to the 3.9 branch.
Props whyisjake, sstoqnov.

Location:

branches/3.9

Files:

• . (modified) (1 prop)
• src/wp-admin/admin-ajax.php (modified) (1 diff)
• src/wp-admin/includes/ajax-actions.php (modified) (2 diffs)

branches/3.9/src/wp-admin/admin-ajax.php

@@ -33 +33 @@
 require_once( ABSPATH . 'wp-admin/includes/ajax-actions.php' );
 
-@header( 'Content-Type: text/html; charset=' . get_option( 'blog_charset' ) );
+@header( 'Content-Type: text/plain; charset=' . get_option( 'blog_charset' ) );
 @header( 'X-Robots-Tag: noindex' );
 

branches/3.9/src/wp-admin/includes/ajax-actions.php

@@ -1621 +1621 @@
                 'data'    => array(
                     'message'  => __( 'The uploaded file is not a valid image. Please try again.' ),
-                    'filename' => $_FILES['async-upload']['name'],
+                    'filename' => esc_html( $_FILES['async-upload']['name'] ),
                 )
             ) );
@@ -1636 +1636 @@
             'data'    => array(
                 'message'  => $attachment_id->get_error_message(),
-                'filename' => $_FILES['async-upload']['name'],
+                'filename' => esc_html( $_FILES['async-upload']['name'] ),
             )
         ) );