Make WordPress Core


Ignore:
Timestamp:
09/04/2019 05:13:43 PM (7 years ago)
Author:
SergeyBiryukov
Message:

Improve URL validation in wp_validate_redirect().

Merges [45971] to the 4.1 branch.
Props vortfu, whyisjake, peterwilsoncc.

Location:
branches/4.1
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/4.1

  • branches/4.1/src/wp-includes/pluggable.php

    r40190 r45984  
    12601260                return $default;
    12611261
     1262        if ( ! isset( $lp['host'] ) && ! empty( $lp['path'] ) && '/' !== $lp['path'][0] ) {
     1263                $path = '';
     1264                if ( ! empty( $_SERVER['REQUEST_URI'] ) ) {
     1265                        $path = dirname( parse_url( 'http://placeholder' . $_SERVER['REQUEST_URI'], PHP_URL_PATH ) . '?' );
     1266                }
     1267                $location = '/' . ltrim( $path . '/', '/' ) . $location;
     1268        }
     1269
    12621270        // Reject if certain components are set but host is not. This catches urls like https:host.com for which parse_url does not set the host field.
    12631271        if ( ! isset( $lp['host'] ) && ( isset( $lp['scheme'] ) || isset( $lp['user'] ) || isset( $lp['pass'] ) || isset( $lp['port'] ) ) ) {
Note: See TracChangeset for help on using the changeset viewer.