Changeset 46077 for trunk/tests/phpunit/tests/image/dimensions.php

Timestamp:

09/07/2019 01:33:16 AM (6 years ago)

Author:

azaozz

Message:

Media: Improve handling of cases where an uploaded image matches exactly a defined intermediate size. In most of these cases the original image has been edited by the user and is "web ready", there is no need for an identical intermediate image.

Introduces the wp_image_resize_identical_dimensions filter so plugins and themes can determine whether a new image with identical dimensions should be created, defaults to false.

Props wpdennis, HKandulla, galbaras, azaozz.
See #32437.

File:

• trunk/tests/phpunit/tests/image/dimensions.php (modified) (2 diffs)

trunk/tests/phpunit/tests/image/dimensions.php

@@ -132 +132 @@
         // crop 640x480 to fit 640x480 (no change)
         $out = image_resize_dimensions( 640, 480, 640, 480, true );
+        $this->assertFalse( $out );
+
+        // resize 640x480 to fit 640x480 (no change)
+        $out = image_resize_dimensions( 640, 480, 640, 480, false );
+        $this->assertFalse( $out );
+
+        // Test with the filter override.
+        add_filter( 'wp_image_resize_identical_dimensions', '__return_true' );
+
+        // crop 640x480 to fit 640x480 (no change)
+        $out = image_resize_dimensions( 640, 480, 640, 480, true );
         // dst_x, dst_y, src_x, src_y, dst_w, dst_h, src_w, src_h
         $this->assertEquals( array( 0, 0, 0, 0, 640, 480, 640, 480 ), $out );
@@ -139 +150 @@
         // dst_x, dst_y, src_x, src_y, dst_w, dst_h, src_w, src_h
         $this->assertEquals( array( 0, 0, 0, 0, 640, 480, 640, 480 ), $out );
+
+        remove_filter( 'wp_image_resize_identical_dimensions', '__return_true' );
     }