Changeset 46084

Timestamp:

09/08/2019 11:52:43 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Accessibility: Comments: Replace @ with at in the displayed date format.

The @ symbol makes sense in the context of email addresses, but does not have a universal meaning in the context of dates.

Props birgire, afercia, audrasjb, SergeyBiryukov.
Fixes #47893.

Location:

trunk/src

Files:

• wp-admin/comment.php (modified) (1 diff)
• wp-admin/edit-form-comment.php (modified) (1 diff)
• wp-admin/includes/class-wp-comments-list-table.php (modified) (1 diff)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/wp-admin/comment.php

@@ -210 +210 @@
             /* translators: Comment date format. See https://secure.php.net/date */
             get_comment_date( __( 'Y/m/d' ), $comment ),
+            /* translators: Comment time format. See https://secure.php.net/date */
             get_comment_date( __( 'g:i a' ), $comment )
         );

trunk/src/wp-admin/edit-form-comment.php

@@ -104 +104 @@
 <div class="misc-pub-section curtime misc-pub-curtime">
 <?php
-/* translators: Publish box date format, see https://secure.php.net/date */
-$datef = __( 'M j, Y @ H:i' );
+$submitted = sprintf(
+    /* translators: 1: Comment date, 2: Comment time. */
+    __( '%1$s at %2$s' ),
+    /* translators: Publish box date format, see https://secure.php.net/date */
+    date_i18n( _x( 'M j, Y', 'publish box date format' ), strtotime( $comment->comment_date ) ),
+    /* translators: Publish box time format, see https://secure.php.net/date */
+    date_i18n( _x( 'H:i', 'publish box time format' ), strtotime( $comment->comment_date ) )
+);
 ?>
 <span id="timestamp">
 <?php
-printf(
-    /* translators: %s: Comment date. */
-    __( 'Submitted on: %s' ),
-    '<b>' . date_i18n( $datef, strtotime( $comment->comment_date ) ) . '</b>'
-);
+/* translators: %s: Comment date. */
+printf( __( 'Submitted on: %s' ), '<b>' . $submitted . '</b>' );
 ?>
 </span>

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -868 +868 @@
             /* translators: Comment date format. See https://secure.php.net/date */
             get_comment_date( __( 'Y/m/d' ), $comment ),
+            /* translators: Comment time format. See https://secure.php.net/date */
             get_comment_date( __( 'g:i a' ), $comment )
         );

trunk/src/wp-includes/script-loader.php

@@ -1616 +1616 @@
                 'submittedOn' => __( 'Submitted on:' ),
                 /* translators: 1: Month, 2: Day, 3: Year, 4: Hour, 5: Minute. */
-                'dateFormat'  => __( '%1$s %2$s, %3$s @ %4$s:%5$s' ),
+                'dateFormat'  => __( '%1$s %2$s, %3$s at %4$s:%5$s' ),
             )
         );