Changeset 46098

Timestamp:

09/12/2019 09:28:14 PM (7 years ago)

Author:

kadamwhite

Message:

REST API: Return term resources in "edit" context after PUT or POST request.

Props westonruter, dlh.
Fixes #41411.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php (modified) (2 diffs)
• tests/phpunit/tests/rest-api/rest-tags-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php

@@ -469 +469 @@
                 }
 
-                $request->set_param( 'context', 'view' );
+                $request->set_param( 'context', 'edit' );
 
                 /**
@@ -571 +571 @@
                 }
 
-                $request->set_param( 'context', 'view' );
+                $request->set_param( 'context', 'edit' );
 
                 /** This action is documented in wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php */

trunk/tests/phpunit/tests/rest-api/rest-tags-controller.php

@@ -1270 +1270 @@
         }
 
+        /**
+         * @ticket 41411
+         */
+        public function test_editable_response_uses_edit_context() {
+                wp_set_current_user( self::$administrator );
+
+                $view_field = 'view_only_field';
+                $edit_field = 'edit_only_field';
+
+                register_rest_field(
+                        'tag',
+                        $view_field,
+                        array(
+                                'context'      => array( 'view' ),
+                                'get_callback' => '__return_empty_string',
+                        )
+                );
+
+                register_rest_field(
+                        'tag',
+                        $edit_field,
+                        array(
+                                'context'      => array( 'edit' ),
+                                'get_callback' => '__return_empty_string',
+                        )
+                );
+
+                $create = new WP_REST_Request( 'POST', '/wp/v2/tags' );
+                $create->set_param( 'name', 'My New Term' );
+                $response = rest_get_server()->dispatch( $create );
+                $this->assertEquals( 201, $response->get_status() );
+                $data = $response->get_data();
+                $this->assertArrayHasKey( $edit_field, $data );
+                $this->assertArrayNotHasKey( $view_field, $data );
+
+                $update = new WP_REST_Request( 'PUT', '/wp/v2/tags/' . $data['id'] );
+                $update->set_param( 'name', 'My Awesome New Term' );
+                $response = rest_get_server()->dispatch( $update );
+                $this->assertEquals( 200, $response->get_status() );
+                $data = $response->get_data();
+                $this->assertArrayHasKey( $edit_field, $data );
+                $this->assertArrayNotHasKey( $view_field, $data );
+        }
+
         public function additional_field_get_callback( $object, $request ) {
                 return 123;