Changeset 46102 for trunk/tests/phpunit/tests/menu/nav-menu.php

Timestamp:

09/13/2019 05:57:57 PM (7 years ago)

Author:

desrosj

Message:

Menus: Nav menu locations should not be integers.

When nav menu location slugs are integers, some hard to debug results can occur. register_nav_menus() utilizes array_merge() which renumbers numeric indexes, starting from 0. Because of this, numeric menu locations will almost always be changed.

This change introduces a _doing_it_wrong() notice to inform developers that nav menu locations should always be strings.

Props audrasjb, desrosj, welcher.
Fixes #45361.

File:

• trunk/tests/phpunit/tests/menu/nav-menu.php (modified) (2 diffs)

trunk/tests/phpunit/tests/menu/nav-menu.php

@@ -183 +183 @@
          * Technically possible to register menu locations numerically.
          *
+         * @expectedIncorrectUsage register_nav_menus
+         *
          * @covers ::wp_map_nav_menu_locations()
          */
@@ -205 +207 @@
         /**
          * Technically possible old nav menu locations were registered numerically.
+         *
+         * @expectedIncorrectUsage register_nav_menus
          *
          * @covers wp_map_nav_menu_locations()