Changeset 46125 for trunk/src/wp-admin/includes/class-automatic-upgrader-skin.php

Timestamp:

09/15/2019 10:41:03 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernisation: Introduce the spread operator in wp-admin/includes/class-*-upgrader-skin.php.

Rather than relying func_get_args() to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

File:

• trunk/src/wp-admin/includes/class-automatic-upgrader-skin.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-automatic-upgrader-skin.php

@@ -59 +59 @@
     /**
      * @param string|array|WP_Error $data
+     * @param mixed                 ...$args Optional text replacements.
      */
-    public function feedback( $data ) {
+    public function feedback( $data, ...$args ) {
         if ( is_wp_error( $data ) ) {
             $string = $data->get_error_message();
@@ -73 +74 @@
 
         if ( strpos( $string, '%' ) !== false ) {
-            $args = func_get_args();
-            $args = array_splice( $args, 1 );
             if ( ! empty( $args ) ) {
                 $string = vsprintf( $string, $args );