Changeset 46125 for trunk/src/wp-admin/includes/class-wp-upgrader-skin.php

Timestamp:

09/15/2019 10:41:03 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Code Modernisation: Introduce the spread operator in wp-admin/includes/class-*-upgrader-skin.php.

Rather than relying func_get_args() to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.

File:

• trunk/src/wp-admin/includes/class-wp-upgrader-skin.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-upgrader-skin.php

@@ -141 +141 @@
     /**
      * @param string $string
-     */
-    public function feedback( $string ) {
+     * @param mixed  ...$args Optional text replacements.
+     */
+    public function feedback( $string, ...$args ) {
         if ( isset( $this->upgrader->strings[ $string ] ) ) {
             $string = $this->upgrader->strings[ $string ];
@@ -148 +149 @@
 
         if ( strpos( $string, '%' ) !== false ) {
-            $args = func_get_args();
-            $args = array_splice( $args, 1 );
             if ( $args ) {
                 $args   = array_map( 'strip_tags', $args );