Changeset 46145

Timestamp:

09/15/2019 11:55:42 AM (7 years ago)

Author:

SergeyBiryukov

Message:

Code Modernisation: Replace call_user_func_array() in tests/phpunit/tests/db.php with dynamic function calls.

Props jrf.
See #47678.

File:

• trunk/tests/phpunit/tests/db.php (modified) (3 diffs)

trunk/tests/phpunit/tests/db.php

@@ -423 +423 @@
                 global $wpdb;
 
-                // $query is the first argument to be passed to wpdb::prepare()
-                array_unshift( $args, $query );
-
-                // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged
-                $prepared = @call_user_func_array( array( $wpdb, 'prepare' ), $args );
+                // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged,WordPress.DB.PreparedSQL
+                $prepared = @$wpdb->prepare( $query, ...$args );
                 $this->assertEquals( $expected, $prepared );
         }
@@ -1367 +1364 @@
                 }
 
-                array_unshift( $values, $sql );
-
-                $sql = call_user_func_array( array( $wpdb, 'prepare' ), $values );
+                // phpcs:ignore WordPress.DB.PreparedSQL
+                $sql = $wpdb->prepare( $sql, ...$values );
                 $this->assertEquals( $expected, $sql );
         }
@@ -1387 +1383 @@
                 }
 
-                $sql = call_user_func_array( array( $wpdb, 'prepare' ), array( $sql, $values ) );
+                // phpcs:ignore WordPress.DB.PreparedSQL
+                $sql = $wpdb->prepare( $sql, $values );
                 $this->assertEquals( $expected, $sql );
         }