Changeset 46148

Timestamp:

09/16/2019 09:57:30 AM (5 years ago)

Author:

SergeyBiryukov

Message:

XML-RPC: Avoid a PHP warning in wp_xmlrpc_server::minimum_args() if $args is not an array.

Correct the documentation to clarify that array is the only acceptable type for $args.

Props bitcomplex, dkarfa.
Fixes #48046.

File:

• trunk/src/wp-includes/class-wp-xmlrpc-server.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-xmlrpc-server.php

@@ -728 +728 @@
      * @since 3.4.0
      *
-     * @param string|array $args Sanitize single string or array of strings.
-     * @param int $count         Minimum number of arguments.
+     * @param array $args  An array of arguments to check.
+     * @param int   $count Minimum number of arguments.
      * @return bool if `$args` contains at least $count arguments.
      */
     protected function minimum_args( $args, $count ) {
-        if ( count( $args ) < $count ) {
+        if ( ! is_array( $args ) || count( $args ) < $count ) {
             $this->error = new IXR_Error( 400, __( 'Insufficient arguments passed to this XML-RPC method.' ) );
             return false;