Changeset 46160

Timestamp:

09/17/2019 07:57:18 PM (5 years ago)

Author:

desrosj

Message:

Posts, Post Types: Allow support arguments to be specified when registering post types.

The add_post_type_support() function accepts an optional third parameter that allows extra arguments to be supplied to configure post type support for a given feature. However, because of how register_post_type() and WP_Post_Type->add_supports() work, it is currently impossible to pass these additional arguments when initially registering a post type with register_post_type().

This change makes it possible to supply additional arguments for a feature using the supports argument of register_post_type().

Props MaximeCulea, seuser, desrosj, johnbillion.
Fixes #40413.

Location:

trunk

Files:

• src/wp-includes/class-wp-post-type.php (modified) (1 diff)
• tests/phpunit/tests/post/wpPostType.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-post-type.php

@@ -514 +514 @@
     public function add_supports() {
         if ( ! empty( $this->supports ) ) {
-            add_post_type_support( $this->name, $this->supports );
+            foreach ( $this->supports as $feature => $args ) {
+                if ( is_array( $args ) ) {
+                    add_post_type_support( $this->name, $feature, $args );
+                } else {
+                    add_post_type_support( $this->name, $args );
+                }
+            }
             unset( $this->supports );
         } elseif ( false !== $this->supports ) {

trunk/tests/phpunit/tests/post/wpPostType.php

@@ -63 +63 @@
     }
 
+    /**
+     * Test that supports can optionally receive nested args.
+     *
+     * @ticket 40413
+     */
+    public function test_add_supports_custom_with_args() {
+        $post_type        = 'cpt';
+        $post_type_object = new WP_Post_Type(
+            $post_type,
+            array(
+                'supports' => array(
+                    'support_with_args' => array(
+                        'arg1',
+                        'arg2',
+                    ),
+                    'support_without_args',
+                ),
+            )
+        );
+
+        $post_type_object->add_supports();
+        $post_type_supports = get_all_post_type_supports( $post_type );
+
+        $post_type_object->remove_supports();
+        $post_type_supports_after = get_all_post_type_supports( $post_type );
+
+        $this->assertEqualSets(
+            array(
+                'support_with_args'    => array(
+                    array(
+                        'arg1',
+                        'arg2',
+                    ),
+                ),
+                'support_without_args' => true,
+            ),
+            $post_type_supports
+        );
+        $this->assertEqualSets( array(), $post_type_supports_after );
+    }
+
     public function test_does_not_add_query_var_if_not_public() {
         $this->set_permalink_structure( '/%postname%' );