Changeset 46164 for trunk/tests/phpunit/tests/dependencies/scripts.php

Timestamp:

09/18/2019 02:49:30 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Script Loader: Introduce HTML5 support for scripts and styles.

When a theme declares HTML5 support for script and styles via add_theme_support( 'html5', array( 'script', 'style' ) ), the type="text/javascript" and type="text/css" attributes are omitted.

These attributes are unnecessary in HTML5 and cause warnings in the W3C Markup Validation Service.

Props sasiddiqui, swissspidy, knutsp, SergeyBiryukov.
See #42804.

File:

• trunk/tests/phpunit/tests/dependencies/scripts.php (modified) (2 diffs)

trunk/tests/phpunit/tests/dependencies/scripts.php

@@ -45 +45 @@
         wp_enqueue_script( 'empty-deps-version', 'example.com', array(), 1.2 );
         wp_enqueue_script( 'empty-deps-null-version', 'example.com', array(), null );
+
         $ver       = get_bloginfo( 'version' );
         $expected  = "<script type='text/javascript' src='http://example.com?ver=$ver'></script>\n";
@@ -55 +56 @@
         // No scripts left to print
         $this->assertEquals( '', get_echo( 'wp_print_scripts' ) );
+    }
+
+    /**
+     * @ticket 42804
+     */
+    function test_wp_enqueue_script_with_html5_support_does_not_contain_type_attribute() {
+        add_theme_support( 'html5', array( 'script' ) );
+
+        $GLOBALS['wp_scripts']                  = new WP_Scripts();
+        $GLOBALS['wp_scripts']->default_version = get_bloginfo( 'version' );
+
+        wp_enqueue_script( 'empty-deps-no-version', 'example.com' );
+
+        $ver      = get_bloginfo( 'version' );
+        $expected = "<script src='http://example.com?ver=$ver'></script>\n";
+
+        $this->assertEquals( $expected, get_echo( 'wp_print_scripts' ) );
     }