Changeset 46169

Timestamp:

09/18/2019 10:29:53 PM (5 years ago)

Author:

whyisjake

Message:

Accesibility: Replace wp-a11y.js with @wordpress/a11y package

Continuation of [46167]. This fixes the tests that ended up broken following the previous commit.

We've extracted wp-includes/wp-a11y.js to a reusable package wordpress/a11y which is published on NPM. Let's make sure this package is also
used in WordPress core. Once all the JavaScript is built using webpack, we can also import this package wherever it is used and configure
webpack to load is an external.

Props, garrett-eclipse

Fixes #45066

File:

• trunk/tests/phpunit/tests/dependencies/scripts.php (modified) (4 diffs)

trunk/tests/phpunit/tests/dependencies/scripts.php

@@ -681 +681 @@
 
         wp_default_scripts( $wp_scripts );
+        wp_default_packages( $wp_scripts );
 
         $wp_scripts->base_url  = '';
@@ -706 +707 @@
 
         wp_default_scripts( $wp_scripts );
+        wp_default_packages( $wp_scripts );
 
         $wp_scripts->base_url  = '';
@@ -740 +742 @@
         $wp_scripts->do_concat = true;
 
-        $expected_tail = "<script type='text/javascript' src='/customize-dependency.js'></script>\n";
+        $expected_tail  = "<script type='text/javascript' src='/customize-dependency.js'></script>\n";
         $expected_tail .= "<script type='text/javascript'>\n";
         $expected_tail .= "tryCustomizeDependency()\n";
@@ -749 +751 @@
         wp_add_inline_script( $handle, 'tryCustomizeDependency()' );
 
-        // Open a buffer to get the output of `wp_print_scripts`.
-        ob_start();
         wp_print_scripts();
-        $print_scripts = ob_get_clean();
+        $print_scripts = get_echo( '_print_scripts' );
 
         $tail = substr( $print_scripts, strrpos( $print_scripts, "<script type='text/javascript' src='/customize-dependency.js'>" ) );