Changeset 46175 for trunk/src/wp-includes/comment.php

Timestamp:

09/19/2019 01:48:54 AM (7 years ago)

Author:

boonebgorges

Message:

Improve do_enclose() logic on post publish.

Removing the direct SQL query in do_all_pings() improves filterability.

As part of this change, the signature of do_enclose() is changed so that
a null $content parameter can be passed, with the $content then inferred
from the $post passed in the second parameter. In addition, the second
parameter was modified so that a post ID or a WP_Post object can be
provided. These changes make it possible to trigger enclosure checks with
a post ID alone (as in do_all_pings()) and also brings the function
signature in line with do_trackbacks() and pingback().

Props dshanske, spacedmonkey, janw.oostendorp, mrmadhat, birgire.
See #36824.

File:

• trunk/src/wp-includes/comment.php (modified) (1 diff)

trunk/src/wp-includes/comment.php

@@ -2640 +2640 @@
         }
 
-        // Do Enclosures
-        while ( $enclosure = $wpdb->get_row( "SELECT ID, post_content, meta_id FROM {$wpdb->posts}, {$wpdb->postmeta} WHERE {$wpdb->posts}.ID = {$wpdb->postmeta}.post_id AND {$wpdb->postmeta}.meta_key = '_encloseme' LIMIT 1" ) ) {
-                delete_metadata_by_mid( 'post', $enclosure->meta_id );
-                do_enclose( $enclosure->post_content, $enclosure->ID );
+        // Do enclosures.
+        $enclosures = get_posts(
+                array(
+                        'post_type'        => get_post_types(),
+                        'suppress_filters' => false,
+                        'nopaging'         => true,
+                        'meta_key'         => '_encloseme',
+                        'fields'           => 'ids',
+                )
+        );
+
+        foreach ( $enclosure as $enclosure ) {
+                delete_post_meta( $enclosure, '_encloseme' );
+                do_enclose( null, $enclosure->ID );
         }