Changeset 46176

Timestamp:

09/19/2019 01:53:03 AM (5 years ago)

Author:

boonebgorges

Message:

PHPCS: Fix coding standards violations in do_enclose().

• Use strict checking when appropriate in in_array() checks.
• Improved comment formatting.
• Yoda and strict equality checks where appropriate.

See #36824.

File:

• trunk/src/wp-includes/functions.php (modified) (6 diffs)

trunk/src/wp-includes/functions.php

@@ -812 +812 @@
     global $wpdb;
 
-    //TODO: Tidy this ghetto code up and make the debug code optional
+    // @todo Tidy this code and make the debug code optional.
     include_once( ABSPATH . WPINC . '/class-IXR.php' );
 
@@ -831 +831 @@
 
     foreach ( $pung as $link_test ) {
-        if ( ! in_array( $link_test, $post_links_temp ) ) { // link no longer in post
+        // Link is no longer in post.
+        if ( ! in_array( $link_test, $post_links_temp, true ) ) {
             $mids = $wpdb->get_col( $wpdb->prepare( "SELECT meta_id FROM $wpdb->postmeta WHERE post_id = %d AND meta_key = 'enclosure' AND meta_value LIKE %s", $post->ID, $wpdb->esc_like( $link_test ) . '%' ) );
             foreach ( $mids as $mid ) {
@@ -840 +841 @@
 
     foreach ( (array) $post_links_temp as $link_test ) {
-        if ( ! in_array( $link_test, $pung ) ) { // If we haven't pung it already
+        // If we haven't pung it already.
+        if ( ! in_array( $link_test, $pung, true ) ) {
             $test = @parse_url( $link_test );
             if ( false === $test ) {
@@ -847 +849 @@
             if ( isset( $test['query'] ) ) {
                 $post_links[] = $link_test;
-            } elseif ( isset( $test['path'] ) && ( $test['path'] != '/' ) && ( $test['path'] != '' ) ) {
+            } elseif ( isset( $test['path'] ) && ( '/' !== $test['path'] ) && ( '' !== $test['path'] ) ) {
                 $post_links[] = $link_test;
             }
@@ -867 +869 @@
 
     foreach ( (array) $post_links as $url ) {
-        if ( $url != '' && ! $wpdb->get_var( $wpdb->prepare( "SELECT post_id FROM $wpdb->postmeta WHERE post_id = %d AND meta_key = 'enclosure' AND meta_value LIKE %s", $post->ID, $wpdb->esc_like( $url ) . '%' ) ) ) {
+        if ( '' !== $url && ! $wpdb->get_var( $wpdb->prepare( "SELECT post_id FROM $wpdb->postmeta WHERE post_id = %d AND meta_key = 'enclosure' AND meta_value LIKE %s", $post->ID, $wpdb->esc_like( $url ) . '%' ) ) ) {
 
             $headers = wp_get_http_headers( $url );
@@ -890 +892 @@
                 }
 
-                if ( in_array( substr( $type, 0, strpos( $type, '/' ) ), $allowed_types ) ) {
+                if ( in_array( substr( $type, 0, strpos( $type, '/' ) ), $allowed_types, true ) ) {
                     add_post_meta( $post->ID, 'enclosure', "$url\n$len\n$mime\n" );
                 }