Changeset 46225

Timestamp:

09/21/2019 12:48:29 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Use the ** operator instead of the pow() function in wp_convert_bytes_to_hr() for better performance.

Use the MB_IN_BYTES constant instead of the pow() function in WP_Customize_Manager::_validate_header_video() for better readability.

Props ayeshrajans, jrf.
Fixes #48083.

Location:

trunk/src/wp-includes

Files:

• class-wp-customize-manager.php (modified) (1 diff)
• deprecated.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-customize-manager.php

@@ -5927 +5927 @@
         if ( $video ) {
             $size = filesize( $video );
-            if ( 8 < $size / pow( 1024, 2 ) ) { // Check whether the size is larger than 8MB.
+            if ( $size > 8 * MB_IN_BYTES ) {
                 $validity->add(
                     'size_too_large',

trunk/src/wp-includes/deprecated.php

@@ -3347 +3347 @@
     $log   = log( $bytes, KB_IN_BYTES );
     $power = (int) $log;
-    $size  = pow( KB_IN_BYTES, $log - $power );
+    $size  = KB_IN_BYTES ** ( $log - $power );
 
     if ( ! is_nan( $size ) && array_key_exists( $power, $units ) ) {