Changeset 46231

Timestamp:

09/21/2019 04:05:13 PM (4 years ago)

Author:

ocean90

Message:

Site Health: Don't verify SSL certificate when testing the local site.

The SSL certificate may be self-signed which prevents various tests from returning proper results. Since the Cron API and file editors don't verify the certificate the tests shouldn't either.

Props Clorith, ocean90.
Fixes #47957.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-site-health-auto-updates.php (modified) (2 diffs)
• class-wp-site-health.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php

@@ -96 +96 @@
             'Cache-Control' => 'no-cache',
         );
+        /** This filter is documented in wp-includes/class-wp-http-streams.php */
+        $sslverify = apply_filters( 'https_local_ssl_verify', false );
 
         // Include Basic auth in loopback requests.
@@ -109 +111 @@
         );
 
-        $test = wp_remote_get( $url, compact( 'cookies', 'headers', 'timeout' ) );
+        $test = wp_remote_get( $url, compact( 'cookies', 'headers', 'timeout', 'sslverify' ) );
 
         if ( is_wp_error( $test ) ) {

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -1678 +1678 @@
             'X-WP-Nonce'    => wp_create_nonce( 'wp_rest' ),
         );
+        /** This filter is documented in wp-includes/class-wp-http-streams.php */
+        $sslverify = apply_filters( 'https_local_ssl_verify', false );
 
         // Include Basic auth in loopback requests.
@@ -1694 +1696 @@
         );
 
-        $r = wp_remote_get( $url, compact( 'cookies', 'headers', 'timeout' ) );
+        $r = wp_remote_get( $url, compact( 'cookies', 'headers', 'timeout', 'sslverify' ) );
 
         if ( is_wp_error( $r ) ) {
@@ -2001 +2003 @@
             'Cache-Control' => 'no-cache',
         );
+        /** This filter is documented in wp-includes/class-wp-http-streams.php */
+        $sslverify = apply_filters( 'https_local_ssl_verify', false );
 
         // Include Basic auth in loopback requests.
@@ -2009 +2013 @@
         $url = admin_url();
 
-        $r = wp_remote_get( $url, compact( 'cookies', 'headers', 'timeout' ) );
+        $r = wp_remote_get( $url, compact( 'cookies', 'headers', 'timeout', 'sslverify' ) );
 
         if ( is_wp_error( $r ) ) {