Changeset 46262

Timestamp:

09/23/2019 06:54:16 PM (5 years ago)

Author:

johnbillion

Message:

Build/Test tools: Ensure the create_and_get() factory method returns the appropriate WP_Error when creating a term fails.

Fixes: #47952

Location:

trunk/tests/phpunit/includes/factory

Files:

• class-wp-unittest-factory-for-term.php (modified) (1 diff)
• class-wp-unittest-factory-for-thing.php (modified) (1 diff)

trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-term.php

@@ -86 +86 @@
     public function create_and_get( $args = array(), $generation_definitions = null ) {
         $term_id  = $this->create( $args, $generation_definitions );
+
+        if ( is_wp_error( $term_id ) ) {
+            return $term_id;
+        }
+
         $taxonomy = isset( $args['taxonomy'] ) ? $args['taxonomy'] : $this->taxonomy;
         return get_term( $term_id, $taxonomy );

trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-thing.php

@@ -80 +80 @@
     public function create_and_get( $args = array(), $generation_definitions = null ) {
         $object_id = $this->create( $args, $generation_definitions );
+
+        if ( is_wp_error( $object_id ) ) {
+            return $object_id;
+        }
+
         return $this->get_object_by_id( $object_id );
     }