Changeset 46267

Timestamp:

09/23/2019 07:38:56 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Site Health: Improve wording for PHP update warning.

Props danieltj, garrett-eclipse, marybaum, afragen, chetan200891.
Fixes #47644.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (6 diffs)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -261 +261 @@
                                         $result['label']  = sprintf(
                                                 /* translators: %s: The current version of WordPress installed on this site. */
-                                                __( 'Your WordPress version is up to date (%s)' ),
+                                                __( 'Your version of WordPress (%s) is up to date' ),
                                                 $core_current_version
                                         );
@@ -655 +655 @@
                         'label'       => sprintf(
                                 /* translators: %s: The current PHP version. */
-                                __( 'PHP is up to date (%s)' ),
+                                __( 'Your version of PHP (%s) is up to date' ),
                                 PHP_VERSION
                         ),
@@ -665 +665 @@
                         'description' => sprintf(
                                 '<p>%s</p>',
-                                __( 'PHP is the programming language we use to build and maintain WordPress. Newer versions of PHP are both faster and more secure, so updating will have a positive effect on your site&#8217;s performance.' )
+                                sprintf(
+                                        /* translators: %s: The minimum recommended PHP version. */
+                                        __( 'PHP is the programming language used to build and maintain WordPress. Newer versions of PHP are faster and more secure, so staying up to date will help your site&#8217;s overall performance and security. The minimum recommended version of PHP is %s.' ),
+                                        $response['recommended_version']
+                                )
                         ),
                         'actions'     => sprintf(
@@ -682 +686 @@
                 }
 
-                // The PHP version is older than the recommended version, but still acceptable.
+                // The PHP version is older than the recommended version, but still receiving active support.
                 if ( $response['is_supported'] ) {
-                        $result['label']  = __( 'We recommend that you update PHP' );
+                        $result['label'] = sprintf(
+                                /* translators: %s: The server PHP version. */
+                                __( 'Your version of PHP (%s) is out of date' ),
+                                PHP_VERSION
+                        );
                         $result['status'] = 'recommended';
 
@@ -692 +700 @@
                 // The PHP version is only receiving security fixes.
                 if ( $response['is_secure'] ) {
-                        $result['label']  = __( 'Your PHP version should be updated' );
+                        $result['label'] = sprintf(
+                                /* translators: %s: The server PHP version. */
+                                __( 'Your version of PHP (%s) should be updated' ),
+                                PHP_VERSION
+                        );
                         $result['status'] = 'recommended';
 
@@ -699 +711 @@
 
                 // Anything no longer secure must be updated.
-                $result['label']          = __( 'Your PHP version requires an update' );
+                $result['label'] = sprintf(
+                        /* translators: %s: The server PHP version. */
+                        __( 'Your version of PHP (%s) requires an update' ),
+                        PHP_VERSION
+                );
                 $result['status']         = 'critical';
                 $result['badge']['label'] = __( 'Security' );