Changeset 46272 for trunk/src/wp-includes/rest-api.php

Timestamp:

09/23/2019 08:24:59 PM (6 years ago)

Author:

kadamwhite

Message:

REST API: Introduce WP_Post_Type::get_rest_controller() caching method to prevent unnecessary REST controller construction.

Cache REST controller references on their associated post type object to prevent unnecessary controller re-instantiation, which previously caused "rest_prepare_{$post_type}" and "rest_{$post_type}_query" to run twice per request.

Props TimothyBlynJacobs, patrelentlesstechnologycom.
Fixes #45677.

File:

• trunk/src/wp-includes/rest-api.php (modified) (1 diff)

trunk/src/wp-includes/rest-api.php

@@ -193 +193 @@
 function create_initial_rest_routes() {
     foreach ( get_post_types( array( 'show_in_rest' => true ), 'objects' ) as $post_type ) {
-        $class = ! empty( $post_type->rest_controller_class ) ? $post_type->rest_controller_class : 'WP_REST_Posts_Controller';
-
-        if ( ! class_exists( $class ) ) {
-            continue;
-        }
-        $controller = new $class( $post_type->name );
-        if ( ! is_subclass_of( $controller, 'WP_REST_Controller' ) ) {
+        $controller = $post_type->get_rest_controller();
+
+        if ( ! $controller ) {
             continue;
         }