Changeset 46272 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

Timestamp:

09/23/2019 08:24:59 PM (5 years ago)

Author:

kadamwhite

Message:

REST API: Introduce WP_Post_Type::get_rest_controller() caching method to prevent unnecessary REST controller construction.

Cache REST controller references on their associated post type object to prevent unnecessary controller re-instantiation, which previously caused "rest_prepare_{$post_type}" and "rest_{$post_type}_query" to run twice per request.

Props TimothyBlynJacobs, patrelentlesstechnologycom.
Fixes #45677.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php

@@ -1593 +1593 @@
      */
     protected function check_read_post_permission( $post, $request ) {
-        $posts_controller = new WP_REST_Posts_Controller( $post->post_type );
         $post_type        = get_post_type_object( $post->post_type );
+        $posts_controller = $post_type->get_rest_controller();
+
+        // Ensure the posts controller is specifically a WP_REST_Posts_Controller instance
+        // before using methods specific to that controller.
+        if ( ! $posts_controller instanceof WP_REST_Posts_Controller ) {
+            $posts_controller = new WP_REST_Posts_Controller( $post->post_type );
+        }
 
         $has_password_filter = false;