Changeset 46272 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php

Timestamp:

09/23/2019 08:24:59 PM (5 years ago)

Author:

kadamwhite

Message:

REST API: Introduce WP_Post_Type::get_rest_controller() caching method to prevent unnecessary REST controller construction.

Cache REST controller references on their associated post type object to prevent unnecessary controller re-instantiation, which previously caused "rest_prepare_{$post_type}" and "rest_{$post_type}_query" to run twice per request.

Props TimothyBlynJacobs, patrelentlesstechnologycom.
Fixes #45677.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php

@@ -50 +50 @@
     public function __construct( $parent_post_type ) {
         $this->parent_post_type  = $parent_post_type;
-        $this->parent_controller = new WP_REST_Posts_Controller( $parent_post_type );
         $this->namespace         = 'wp/v2';
         $this->rest_base         = 'revisions';
         $post_type_object        = get_post_type_object( $parent_post_type );
         $this->parent_base       = ! empty( $post_type_object->rest_base ) ? $post_type_object->rest_base : $post_type_object->name;
+        $this->parent_controller = $post_type_object->get_rest_controller();
+
+        if ( ! $this->parent_controller ) {
+            $this->parent_controller = new WP_REST_Posts_Controller( $parent_post_type );
+        }
     }