Changeset 46276

Timestamp:

09/23/2019 08:51:38 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Site Health: Use WP_Automatic_Updater::is_disabled() to check whether automatic updates are disabled.

The previous check for DISALLOW_FILE_MODS and AUTOMATIC_UPDATER_DISABLED constants didn't always provide accurate results.

Props Clorith, kraftner, afragen.
Fixes #47869.

File:

• trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php

@@ -27 +27 @@
         public function run_tests() {
                 $tests = array(
-                        $this->test_constants( 'DISALLOW_FILE_MODS', false ),
-                        $this->test_constants( 'AUTOMATIC_UPDATER_DISABLED', false ),
                         $this->test_constants( 'WP_AUTO_UPDATE_CORE', true ),
                         $this->test_wp_version_check_attached(),
                         $this->test_filters_automatic_updater_disabled(),
+                        $this->test_wp_automatic_updates_disabled(),
                         $this->test_if_failed_update(),
                         $this->test_vcs_abspath(),
@@ -160 +159 @@
 
         /**
+         * Check if automatic updates are disabled.
+         *
+         * @since 5.3.0
+         *
+         * @return array|bool The test results. False if auto updates are enabled.
+         */
+        public function test_wp_automatic_updates_disabled() {
+                if ( ! class_exists( 'WP_Automatic_Updater' ) ) {
+                        require_once( ABSPATH . 'wp-admin/includes/class-wp-automatic-updates.php' );
+                }
+
+                $auto_updates = new WP_Automatic_Updater();
+
+                if ( ! $auto_updates->is_disabled() ) {
+                        return false;
+                }
+
+                return array(
+                        'description' => __( 'All automatic updates are disabled.' ),
+                        'severity'    => 'fail',
+                );
+        }
+
+        /**
          * Check if automatic updates have tried to run, but failed, previously.
          *
          * @since 5.2.0
          *
-         * @return array|bool The test results. false if the auto updates failed.
+         * @return array|bool The test results. False if the auto updates failed.
          */
         function test_if_failed_update() {
@@ -309 +332 @@
          * @global WP_Filesystem_Base $wp_filesystem WordPress filesystem subclass.
          *
-         * @return array|bool The test results. false if they're not writeable.
+         * @return array|bool The test results. False if they're not writeable.
          */
         function test_all_files_writable() {
@@ -389 +412 @@
          * @since 5.2.0
          *
-         * @return array|bool The test results. false if it isn't a development version.
+         * @return array|bool The test results. False if it isn't a development version.
          */
         function test_accepts_dev_updates() {