Changeset 46280

Timestamp:

09/23/2019 09:17:04 PM (5 years ago)

Author:

SergeyBiryukov

Message:

REST API: Use delta comparison for floating date tests added in [46252] to avoid race conditions.

See #39953.

File:

• trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (4 diffs)

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -4414 +4414 @@
     }
 
+    /**
+     * @ticket 39953
+     */
     public function test_putting_same_publish_date_does_not_remove_floating_date() {
 
@@ -4441 +4444 @@
         $body     = $response->get_data();
 
-        $this->assertEquals( $get_body['date'], $body['date'] );
-        $this->assertEquals( $get_body['date_gmt'], $body['date_gmt'] );
+        $this->assertEquals( strtotime( $get_body['date'] ), strtotime( $body['date'] ), 'The dates should be equal', 2 );
+        $this->assertEquals( strtotime( $get_body['date_gmt'] ), strtotime( $body['date_gmt'] ), 'The dates should be equal', 2 );
 
         $this->assertEquals( '0000-00-00 00:00:00', get_post( $post->ID )->post_date_gmt );
     }
 
+    /**
+     * @ticket 39953
+     */
     public function test_putting_different_publish_date_removes_floating_date() {
 
@@ -4482 +4488 @@
         $body     = $response->get_data();
 
-        $this->assertEquals( mysql_to_rfc3339( $new_time ), $body['date'] );
+        $this->assertEquals( strtotime( mysql_to_rfc3339( $new_time ) ), strtotime( $body['date'] ), 'The dates should be equal', 2 );
 
         $this->assertNotEquals( '0000-00-00 00:00:00', get_post( $post->ID )->post_date_gmt );
     }
 
+    /**
+     * @ticket 39953
+     */
     public function test_publishing_post_with_same_date_removes_floating_date() {
 
@@ -4521 +4530 @@
         $body     = $response->get_data();
 
-        $this->assertEquals( $get_body['date'], $body['date'] );
-        $this->assertEquals( $get_body['date_gmt'], $body['date_gmt'] );
+        $this->assertEquals( strtotime( $get_body['date'] ), strtotime( $body['date'] ), 'The dates should be equal', 2 );
+        $this->assertEquals( strtotime( $get_body['date_gmt'] ), strtotime( $body['date_gmt'] ), 'The dates should be equal', 2 );
 
         $this->assertNotEquals( '0000-00-00 00:00:00', get_post( $post->ID )->post_date_gmt );