Changeset 46328

Timestamp:

09/26/2019 08:25:59 PM (5 years ago)

Author:

johnbillion

Message:

Themes: Add a test to ensure get_template_part() does not return a value.

This function must not be modified to return anything due to existing themes which output the return value, for example via echo get_template_part( ... ).

See #40969

Location:

trunk/tests/phpunit

Files:

• data/themedir1/default/template-part.php (added)
• tests/general/template.php (modified) (1 diff)

trunk/tests/phpunit/tests/general/template.php

@@ -628 +628 @@
         $this->assertSame( "<meta name='robots' content='noindex,follow' />\n", $actual_public );
     }
+
+    /**
+     * @ticket 40969
+     */
+    function test_get_template_part_returns_nothing() {
+        ob_start();
+
+        // The `get_template_part()` function must not return anything
+        // due to themes in the wild that echo its return value.
+        $part   = get_template_part( 'template', 'part' );
+        $output = ob_get_clean();
+
+        self::assertSame( 'Template Part', trim( $output ) );
+        self::assertSame( null, $part );
+    }
 }