Changeset 46349 for trunk/src/wp-includes/formatting.php

Timestamp:

09/30/2019 01:29:10 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Comments: Add rel="nofollow ugc" attribute to links in comments.

UGC stands for User Generated Content, and the ugc attribute value is recommended for links within user generated content, such as comments and forum posts.

See ​https://webmasters.googleblog.com/2019/09/evolving-nofollow-new-ways-to-identify.html.

Props audrasjb, joostdevalk, dkarfa, SergeyBiryukov.
Fixes #48022.

File:

• trunk/src/wp-includes/formatting.php (modified) (3 diffs)

trunk/src/wp-includes/formatting.php

@@ -3013 +3013 @@
 
 /**
- * Adds rel nofollow string to all HTML A elements in content.
- *
- * @since 1.5.0
- *
- * @param string $text Content that may contain HTML A elements.
- * @return string Converted content.
- */
-function wp_rel_nofollow( $text ) {
-    // This is a pre save filter, so text is already escaped.
-    $text = stripslashes( $text );
-    $text = preg_replace_callback( '|<a (.+?)>|i', 'wp_rel_nofollow_callback', $text );
-    return wp_slash( $text );
-}
-
-/**
- * Callback to add rel=nofollow string to HTML A element.
- *
- * Will remove already existing rel="nofollow" and rel='nofollow' from the
- * string to prevent from invalidating (X)HTML.
- *
- * @since 2.3.0
- *
- * @param array $matches Single Match
- * @return string HTML A Element with rel nofollow.
- */
-function wp_rel_nofollow_callback( $matches ) {
+ * Callback to add a rel attribute to HTML A element.
+ *
+ * Will remove already existing string before adding to prevent invalidating (X)HTML.
+ *
+ * @since 5.3.0
+ *
+ * @param array  $matches Single match.
+ * @param string $rel     The rel attribute to add.
+ * @return string HTML A element with the added rel attribute.
+ */
+function wp_rel_callback( $matches, $rel ) {
     $text = $matches[1];
     $atts = wp_kses_hair( $matches[1], wp_allowed_protocols() );
-    $rel  = 'nofollow';
 
     if ( ! empty( $atts['href'] ) ) {
@@ -3052 +3036 @@
 
     if ( ! empty( $atts['rel'] ) ) {
-        $parts = array_map( 'trim', explode( ' ', $atts['rel']['value'] ) );
-        if ( false === array_search( 'nofollow', $parts ) ) {
-            $parts[] = 'nofollow';
-        }
-        $rel = implode( ' ', $parts );
+        $parts     = array_map( 'trim', explode( ' ', $atts['rel']['value'] ) );
+        $rel_array = array_map( 'trim', explode( ' ', $rel ) );
+        $parts     = array_unique( array_merge( $parts, $rel_array ) );
+        $rel       = implode( ' ', $parts );
         unset( $atts['rel'] );
 
@@ -3070 +3053 @@
     }
     return "<a $text rel=\"" . esc_attr( $rel ) . '">';
+}
+
+/**
+ * Adds `rel="nofollow"` string to all HTML A elements in content.
+ *
+ * @since 1.5.0
+ *
+ * @param string $text Content that may contain HTML A elements.
+ * @return string Converted content.
+ */
+function wp_rel_nofollow( $text ) {
+    // This is a pre save filter, so text is already escaped.
+    $text = stripslashes( $text );
+    $rel  = 'nofollow';
+    $text = preg_replace_callback(
+        '|<a (.+?)>|i',
+        function( $matches ) use ( $rel ) {
+            return wp_rel_callback( $matches, $rel );
+        },
+        $text
+    );
+    return wp_slash( $text );
+}
+
+/**
+ * Callback to add `rel="nofollow"` string to HTML A element.
+ *
+ * @since 2.3.0
+ * @deprecated 5.3.0 Use wp_rel_callback()
+ *
+ * @param array $matches Single match.
+ * @return string HTML A Element with `rel="nofollow"`.
+ */
+function wp_rel_nofollow_callback( $matches ) {
+    return wp_rel_callback( $matches, 'nofollow' );
+}
+
+/**
+ * Adds `rel="nofollow ugc"` string to all HTML A elements in content.
+ *
+ * @since 5.3.0
+ *
+ * @param string $text Content that may contain HTML A elements.
+ * @return string Converted content.
+ */
+function wp_rel_ugc( $text ) {
+    // This is a pre save filter, so text is already escaped.
+    $text = stripslashes( $text );
+    $rel  = 'nofollow ugc';
+    $text = preg_replace_callback(
+        '|<a (.+?)>|i',
+        function( $matches ) use ( $rel ) {
+            return wp_rel_callback( $matches, $rel );
+        },
+        $text
+    );
+    return wp_slash( $text );
 }