Changeset 46354 for trunk/src/wp-admin/includes/image-edit.php

Timestamp:

09/30/2019 04:33:39 PM (5 years ago)

Author:

antpb

Message:

Media: Prevents clipping of text when scaling image edit screen.

Props sabernhardt, audrasjb, afercia.
See #47115.

File:

• trunk/src/wp-admin/includes/image-edit.php (modified) (4 diffs)

trunk/src/wp-admin/includes/image-edit.php

@@ -39 +39 @@
     if ( $msg ) {
         if ( isset( $msg->error ) ) {
-            $note = "<div class='error'><p>$msg->error</p></div>";
+            $note = "<div class='error' tabindex='-1' role='alert'><p>$msg->error</p></div>";
         } elseif ( isset( $msg->msg ) ) {
-            $note = "<div class='updated'><p>$msg->msg</p></div>";
+            $note = "<div class='updated' tabindex='-1' role='alert'><p>$msg->msg</p></div>";
         }
     }
@@ -63 +63 @@
                 /* translators: %s: Image width and height in pixels. */
                 __( 'Original dimensions %s' ),
-                $meta['width'] . ' &times; ' . $meta['height']
+                '<span class="imgedit-original-dimensions">' . $meta['width'] . ' &times; ' . $meta['height'] . '</span>'
             );
             ?>
@@ -79 +79 @@
         <input type="text" id="imgedit-scale-height-<?php echo $post_id; ?>" onkeyup="imageEdit.scaleChanged(<?php echo $post_id; ?>, 0, this)" onblur="imageEdit.scaleChanged(<?php echo $post_id; ?>, 0, this)" value="<?php echo isset( $meta['height'] ) ? $meta['height'] : 0; ?>" />
         <span class="imgedit-scale-warn" id="imgedit-scale-warn-<?php echo $post_id; ?>">!</span>
-        <input id="imgedit-scale-button" type="button" onclick="imageEdit.action(<?php echo "$post_id, '$nonce'"; ?>, 'scale')" class="button button-primary" value="<?php esc_attr_e( 'Scale' ); ?>" />
+        <div class="imgedit-scale-button-wrapper"><input id="imgedit-scale-button" type="button" onclick="imageEdit.action(<?php echo "$post_id, '$nonce'"; ?>, 'scale')" class="button button-primary" value="<?php esc_attr_e( 'Scale' ); ?>" /></div>
         </div>
         </fieldset>
@@ -236 +236 @@
 
         <div id="imgedit-crop-<?php echo $post_id; ?>" class="imgedit-crop-wrap">
-        <img id="image-preview-<?php echo $post_id; ?>" onload="imageEdit.imgLoaded('<?php echo $post_id; ?>')" src="<?php echo admin_url( 'admin-ajax.php', 'relative' ); ?>?action=imgedit-preview&amp;_ajax_nonce=<?php echo $nonce; ?>&amp;postid=<?php echo $post_id; ?>&amp;rand=<?php echo rand( 1, 99999 ); ?>" alt="" />
+        <img id="image-preview-<?php echo $post_id; ?>"  src="<?php echo admin_url( 'admin-ajax.php', 'relative' ); ?>?action=imgedit-preview&amp;_ajax_nonce=<?php echo $nonce; ?>&amp;postid=<?php echo $post_id; ?>&amp;rand=<?php echo rand( 1, 99999 ); ?>" alt="" />
         </div>