Changeset 46389

Timestamp:

10/04/2019 09:58:48 PM (5 years ago)

Author:

ocean90

Message:

Customize: Prevent breaking the customizer when site title contains templating syntax.

When the site title is inside an underscore template, syntax defined in wp.template like {{ }} is treated as special characters and will make Underscore treat it as data to be compiled/rendered.

Props pierlo, donmhico.
Fixes #46863.

Location:

trunk/src/wp-includes

Files:

• customize/class-wp-customize-site-icon-control.php (modified) (1 diff)
• media-template.php (modified) (1 diff)

trunk/src/wp-includes/customize/class-wp-customize-site-icon-control.php

@@ -65 +65 @@
                                 <img src="{{ data.attachment.sizes.full ? data.attachment.sizes.full.url : data.attachment.url }}" alt="<?php esc_attr_e( 'Preview as a browser icon' ); ?>"/>
                             </div>
-                            <span class="browser-title" aria-hidden="true"><?php bloginfo( 'name' ); ?></span>
+                            <span class="browser-title" aria-hidden="true"><# print( '<?php bloginfo( 'name' ); ?>' ) #></span>
                         </div>
                         <img class="app-icon-preview" src="{{ data.attachment.sizes.full ? data.attachment.sizes.full.url : data.attachment.url }}" alt="<?php esc_attr_e( 'Preview as an app icon' ); ?>"/>

trunk/src/wp-includes/media-template.php

@@ -1432 +1432 @@
                 <img id="preview-favicon" src="{{ data.url }}" alt="<?php esc_attr_e( 'Preview as a browser icon' ); ?>"/>
             </div>
-            <span class="browser-title" aria-hidden="true"><?php bloginfo( 'name' ); ?></span>
+            <span class="browser-title" aria-hidden="true"><# print( '<?php bloginfo( 'name' ); ?>' ) #></span>
         </div>