Changeset 46395 for trunk/src/wp-includes/theme.php

Timestamp:

10/05/2019 12:53:39 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Themes: In get_theme_mod(), only run the sprintf() replacement on the default value if there's a string format pattern found in the value.

This prevents standalone percent symbols from being stripped out, e.g. in a default value like 100%.

Props aristath, kuus, moonomo, westonruter, davetgreen, daviedR, katielgc, noisysocks, SergeyBiryukov.
Fixes #34290.

File:

• trunk/src/wp-includes/theme.php (modified) (1 diff)

trunk/src/wp-includes/theme.php

@@ -935 +935 @@
 
     if ( is_string( $default ) ) {
-        $default = sprintf( $default, get_template_directory_uri(), get_stylesheet_directory_uri() );
+        // Only run the replacement if an sprintf() string format pattern was found.
+        if ( preg_match( '#(?<!%)%(?:\d+\$?)?s#', $default ) ) {
+            $default = sprintf( $default, get_template_directory_uri(), get_stylesheet_directory_uri() );
+        }
     }