Changeset 46400

Timestamp:

10/05/2019 02:15:13 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Filesystem API: Use strict type check in the in_array() call for the $skip_list parameter in copy_dir() and _copy_dir().

This ensures that parent folders with a numeric name are not accidentally skipped when only a subfolder is intended to be skipped.

Props codex-m.
Fixes #46581.

Location:

trunk/src/wp-admin/includes

Files:

• file.php (modified) (1 diff)
• update-core.php (modified) (1 diff)

trunk/src/wp-admin/includes/file.php

@@ -1706 +1706 @@
 
     foreach ( (array) $dirlist as $filename => $fileinfo ) {
-        if ( in_array( $filename, $skip_list ) ) {
+        if ( in_array( $filename, $skip_list, true ) ) {
             continue;
         }

trunk/src/wp-admin/includes/update-core.php

@@ -1313 +1313 @@
 
     foreach ( (array) $dirlist as $filename => $fileinfo ) {
-        if ( in_array( $filename, $skip_list ) ) {
+        if ( in_array( $filename, $skip_list, true ) ) {
             continue;
         }