Changeset 46413 for trunk/src/wp-includes/class-walker-nav-menu.php

Timestamp:

10/06/2019 03:04:18 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Menus: In Walker_Nav_Menu, Walker_Category, and Walker_Page, properly output link attributes having a legitimate "empty" value, for example an HTML data attribute with a value of zero (0).

Props nevma, AkSDvP, greenshady, SergeyBiryukov.
Fixes #47720.

File:

• trunk/src/wp-includes/class-walker-nav-menu.php (modified) (1 diff)

trunk/src/wp-includes/class-walker-nav-menu.php

@@ -204 +204 @@
         $attributes = '';
         foreach ( $atts as $attr => $value ) {
-            if ( ! empty( $value ) ) {
+            if ( is_scalar( $value ) && '' !== $value && false !== $value ) {
                 $value       = ( 'href' === $attr ) ? esc_url( $value ) : esc_attr( $value );
                 $attributes .= ' ' . $attr . '="' . $value . '"';