Changeset 46418 for trunk/src/wp-includes/media.php

Timestamp:

10/07/2019 12:41:50 PM (6 years ago)

Author:

afercia

Message:

Accessibility: Media: Improve the search media field labelling.

Visible <label> elements benefit all users. The placeholder attribute should not be used as a replacement for visible labels.
Instead, it's supposed to be used only for a short hint to aid users with data entry e.g. a sample value or a brief description of the expected format.

Screen readers may not announce a placeholder attribute at all. Other users may suffer from the lack of a visible label and a placeholder used as replacement, for example:

• users with cognitive disabilities may have trouble remembering what the filled field does
• speech recognition users cannot see the name they can speak to set focus on the field
• low-vision users with high text-size may not be able to see the whole placeholder even when it's visible, if its value is clipped by the edge of the input

Props anevins, audrasjb, karmatosed, azaozz, SergeyBiryukov, afercia.
See #40331.
Fixes #47138.

File:

• trunk/src/wp-includes/media.php (modified) (1 diff)

trunk/src/wp-includes/media.php

@@ -3849 +3849 @@
         'filterByDate'                => __( 'Filter by date' ),
         'filterByType'                => __( 'Filter by type' ),
-        'searchMediaLabel'            => __( 'Search Media' ),
-        'searchMediaPlaceholder'      => __( 'Search media items...' ), // placeholder (no ellipsis)
+        'searchLabel'                 => __( 'Search' ),
+        'searchMediaLabel'            => __( 'Search Media' ), // backwards compatibility pre-5.3
+        'searchMediaPlaceholder'      => __( 'Search media items...' ), // placeholder (no ellipsis), backwards compatibility pre-5.3
         'mediaFound'                  => __( 'Number of media items found: %d' ),
         'mediaFoundHasMoreResults'    => __( 'Number of media items displayed: %d. Scroll the page for more results.' ),