Changeset 46421 for trunk/src/wp-admin/includes/image.php

Timestamp:

10/07/2019 03:28:29 PM (7 years ago)

Author:

azaozz

Message:

Upload: Set custom header with the attachment ID for all uploads from media_handle_upload(). Let the REST API endpoint set it separately.

Props timothyblynjacobs.
Fixes #48200.

File:

• trunk/src/wp-admin/includes/image.php (modified) (3 diffs)

trunk/src/wp-admin/includes/image.php

@@ -253 +253 @@
                 }
 
-                // Set a custom header with the attachment_id.
-                // Used by the browser/client to resume creating image sub-sizes after a PHP fatal error.
-                if ( ! headers_sent() ) {
-                        header( 'X-WP-Upload-Attachment-ID: ' . $attachment_id );
-                }
-
                 // Resize the image
                 $resized = $editor->resize( $threshold, $threshold );
@@ -297 +291 @@
                         // This image cannot be edited.
                         return $image_meta;
-                }
-
-                if ( ! headers_sent() ) {
-                        header( 'X-WP-Upload-Attachment-ID: ' . $attachment_id );
                 }
 
@@ -400 +390 @@
                 // The image cannot be edited.
                 return $image_meta;
-        }
-
-        // Set a custom header with the attachment_id.
-        // Used by the browser/client to resume creating image sub-sizes after a PHP fatal error.
-        if ( ! headers_sent() ) {
-                header( 'X-WP-Upload-Attachment-ID: ' . $attachment_id );
         }