Changeset 46426

Timestamp:

10/07/2019 08:27:20 PM (7 years ago)

Author:

johnbillion

Message:

Pings/Trackbacks: Avoid adding multiple _pingme and _encloseme meta entries to a post when it gets updated prior to pings being done.

Props rebasaurus, whyisjake

Fixes #48014

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/tests/post.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -6801 +6801 @@
 
         if ( get_option( 'default_pingback_flag' ) ) {
-                add_post_meta( $post_id, '_pingme', '1' );
-        }
-        add_post_meta( $post_id, '_encloseme', '1' );
+                add_post_meta( $post_id, '_pingme', '1', true );
+        }
+        add_post_meta( $post_id, '_encloseme', '1', true );
 
         $to_ping = get_to_ping( $post_id );

trunk/tests/phpunit/tests/post.php

@@ -1431 +1431 @@
                 self::assertEquals( strtotime( gmdate( 'Y-m-d H:i:s' ) ), strtotime( $post->post_date_gmt ), 'The dates should be equal', 2 );
         }
+
+        /**
+         * @ticket 48014
+         */
+        public function test_updated_post_should_not_duplicate_enclosure_meta_fields() {
+                $post_id = self::factory()->post->create();
+
+                $encloseme_before = get_post_meta( $post_id, '_encloseme' );
+                $pingme_before    = get_post_meta( $post_id, '_pingme' );
+
+                $updated = wp_update_post( get_post( $post_id ), true );
+
+                $encloseme_after = get_post_meta( $post_id, '_encloseme' );
+                $pingme_after    = get_post_meta( $post_id, '_pingme' );
+
+                $this->assertSame( $post_id, $updated );
+
+                $this->assertCount( 1, $encloseme_before );
+                $this->assertCount( 1, $encloseme_after );
+
+                $this->assertCount( 1, $pingme_before );
+                $this->assertCount( 1, $pingme_after );
+        }
 }