Changeset 46434 for trunk/tests/phpunit/tests/rest-api/rest-server.php

Timestamp:

10/08/2019 04:43:10 AM (6 years ago)

Author:

kadamwhite

Message:

REST API: Permit embedding of the 'self' link relation in the /search endpoint.

Removes a special-case prohibition against embedding 'self' which prevented ?_embed from being used with the /wp/v2/search endpoint.

Props TimothyBlynJacobs, chrisvanpatten, kadamwhite.
Fixes #47684.

File:

• trunk/tests/phpunit/tests/rest-api/rest-server.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-server.php

@@ -570 +570 @@
     /**
      * @depends test_link_embedding
+     * @ticket 47684
      */
     public function test_link_embedding_self() {
@@ -583 +584 @@
         $response = new WP_REST_Response();
 
-        // 'self' should be ignored.
-        $response->add_link( 'self', rest_url( '/test/notembeddable' ), array( 'embeddable' => true ) );
+        // 'self' should not be special-cased, and may be marked embeddable.
+        $response->add_link( 'self', rest_url( '/test/embeddable' ), array( 'embeddable' => true ) );
+
+        $data = rest_get_server()->response_to_data( $response, true );
+
+        $this->assertArrayHasKey( '_embedded', $data );
+    }
+
+    /**
+     * @depends test_link_embedding
+     * @ticket 47684
+     */
+    public function test_link_embedding_self_non_embeddable() {
+        // Register our testing route.
+        rest_get_server()->register_route(
+            'test',
+            '/test/embeddable',
+            array(
+                'methods'  => 'GET',
+                'callback' => array( $this, 'embedded_response_callback' ),
+            )
+        );
+        $response = new WP_REST_Response();
+
+        // 'self' should not be special-cased, and should be ignored if not marked embeddable.
+        $response->add_link( 'self', rest_url( '/test/notembeddable' ) );
 
         $data = rest_get_server()->response_to_data( $response, true );