Changeset 46435 for trunk/src/wp-includes/class-wp-post-type.php

Timestamp:

10/08/2019 01:41:29 PM (5 years ago)

Author:

kadamwhite

Message:

REST API: Ensure rest_controller instantiates the post type's declared REST controller class.

Ensures that the ::get_rest_controller() method will always return an instanceof the expected controller class, or null.
Removes unused private static property $post_type_controllers.

Props dlh, TimothyBlynJacobs.
Fixes #45677.

File:

• trunk/src/wp-includes/class-wp-post-type.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-post-type.php

@@ -344 +344 @@
      * @var WP_REST_Controller $rest_controller
      */
-    private $rest_controller;
+    public $rest_controller;
 
     /**
@@ -723 +723 @@
         }
 
+        if ( ! ( $this->rest_controller instanceof $class ) ) {
+            return null;
+        }
+
         return $this->rest_controller;
     }