Changeset 46441

Timestamp:

10/08/2019 05:44:42 PM (5 years ago)

Author:

johnjamesjacoby

Message:

Network Admin: Improve Site States in List Table rows.

This commit switches a comparison to a Yoda condition, performs a more strict intval() check on the value of the Site Status column, and prevents a specific Site State from appearing in List Table rows when filtering by that same Site State already (to match the behavior of other List Table State implementations.)

Fixes #37684. Props pbiron.

File:

• trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php

@@ -618 +618 @@
         reset( $this->status_list );
 
+        $site_status = isset( $_REQUEST['status'] ) ? wp_unslash( trim( $_REQUEST['status'] ) ) : '';
         foreach ( $this->status_list as $status => $col ) {
-            if ( $_site->{$status} == 1 ) {
+            if ( ( 1 === intval( $_site->{$status} ) ) && ( $site_status !== $status ) ) {
                 $site_states[ $col[0] ] = $col[1];
             }