Changeset 46456 for trunk/src/wp-includes/rest-api.php

Timestamp:

10/10/2019 05:16:44 PM (6 years ago)

Author:

kadamwhite

Message:

REST API: Fix error in _fields filtering logic where only one of several requested sibling properties would be included.

Props kadamwhite, TimothyBlynJacobs.
Fixes #48266.

File:

• trunk/src/wp-includes/rest-api.php (modified) (1 diff)

trunk/src/wp-includes/rest-api.php

@@ -744 +744 @@
         $ref   = &$fields_as_keyed;
         while ( count( $parts ) > 1 ) {
-            $next         = array_shift( $parts );
-            $ref[ $next ] = array();
+            $next = array_shift( $parts );
+            if ( isset( $ref[ $next ] ) && true === $ref[ $next ] ) {
+                // Skip any sub-properties if their parent prop is already marked for inclusion.
+                break 2;
+            }
+            $ref[ $next ] = isset( $ref[ $next ] ) ? $ref[ $next ] : array();
             $ref          = &$ref[ $next ];
         }