Changeset 46459 for trunk/src/wp-admin/includes/image.php

Timestamp:

10/11/2019 07:52:12 AM (6 years ago)

Author:

mikeschroder

Message:

Media: Update fallback previews to support _wp_make_subsizes()

Allows fallback previews (PDF by default, in core) to save image meta
after each size is generated to allow for resuming, and make sizes
immediately available.

Props azaozz, antpb, progremzion, mikeschroder.
See #48111.

File:

• trunk/src/wp-admin/includes/image.php (modified) (1 diff)

trunk/src/wp-admin/includes/image.php

@@ -582 +582 @@
                 // Resize based on the full size image, rather than the source.
                 if ( ! is_wp_error( $uploaded ) ) {
-                    $editor = wp_get_image_editor( $uploaded['path'] );
+                    $image_file = $uploaded['path'];
                     unset( $uploaded['path'] );
 
-                    if ( ! is_wp_error( $editor ) ) {
-                        $metadata['sizes']         = $editor->multi_resize( $merged_sizes );
-                        $metadata['sizes']['full'] = $uploaded;
-                    }
+                    $metadata['sizes'] = array(
+                        'full' => $uploaded,
+                    );
+
+                    // Save the meta data before any image post-processing errors could happen.
+                    wp_update_attachment_metadata( $attachment_id, $metadata );
+
+                    // Create sub-sizes saving the image meta after each.
+                    $metadata = _wp_make_subsizes( $merged_sizes, $image_file, $metadata, $attachment_id );
                 }
             }